-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: add missing bos_token to example templates #11432
base: main
Are you sure you want to change the base?
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
43f2c32
to
1a7f9e3
Compare
Thanks for fixing, can you add some unit tests to ensure that the BOS token isn't added twice in this case? |
Added a test. Is it OK to place it to a new directory ( |
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
13f56c1
to
263ab89
Compare
I would just name the directory |
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
Please update the failing tests to consider the BOS token. |
Oops, this is unexpected to me. I'll fix the enumeration of Jinja files. https://buildkite.com/vllm/fastcheck/builds/10539#0193fc47-aa1b-4af4-8c53-a27c0af8deb1
|
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
I think you also need to update the entrypoints tests to consider the BOS token. |
Actually now that I think more about it... wouldn't it be better to instead update |
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
This pull request has merge conflicts that must be resolved before it can be |
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
Signed-off-by: Toshiki Kataoka <kataoka@pelements.jp>
I suppose this PR could be incremental and it only resolves the inconsistency among example templates.
Sorry. I didn't get the concrete suggestion. Do you mean making
|
This PR updates chat template examples to align with the latest (>=0.4.3)
/v1/chat/completions
spec on BOS.Some chat templates don't contain
bos_token
, especially when it's written before v0.4.3. According to the excellent investigation #9519, the chat serving does not add BOS again, while awkwardness remains in the offline chat interface (to be fixed).