Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] simplify Dockerfile build for ARM64 / GH200 #11212

Merged
merged 9 commits into from
Dec 16, 2024

Conversation

cennn
Copy link
Contributor

@cennn cennn commented Dec 15, 2024

From PR: 10499
Fix Issue: 2021

This contribution focuses on simplifying the Dockerfile build process for ARM64 systems. Unnecessary build from source has been removed and requirements handling has been optimized to ensure the correct installation of torch and bitsandbytes for ARM64+CUDA compatibility. The changes have been tested on the Nvidia GH200 platform with models meta-llama/Llama-3.1-8B and Qwen/Qwen2.5-0.5B-Instruct

The following command was used to build and confirmed working on Nvidia GH200:
docker build . --target vllm-openai --platform "linux/arm64" -t cenncenn/vllm-gh200-openai:v0.6.4.post1 --build-arg max_jobs=66 --build-arg nvcc_threads=2 --build-arg torch_cuda_arch_list="9.0+PTX" --build-arg vllm_fa_cmake_gpu_arches="90-real" --build-arg RUN_WHEEL_CHECK='false'

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Dec 15, 2024
@cennn cennn changed the title [CI/Build] simplify Dockerfile build for ARM64 / GH200 WIP: [CI/Build] simplify Dockerfile build for ARM64 / GH200 Dec 15, 2024
@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 16, 2024
…/causal-conv1d/mamba/flashinfer/bitsandbytes
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great effort!

cc @simon-mo if you can help set up a GH200 machine for testing.

@youkaichao
Copy link
Member

@drikster80 I'm planning to merge this because it contains much less modules to build from source. Your commits are kept here, and thanks for your great contribution!

@drikster80
Copy link
Contributor

@drikster80 I'm planning to merge this because it contains much less modules to build from source. Your commits are kept here, and thanks for your great contribution!

Sounds great. Glad it was able to get tested and merged.

@youkaichao youkaichao enabled auto-merge (squash) December 16, 2024 07:30
@youkaichao youkaichao changed the title WIP: [CI/Build] simplify Dockerfile build for ARM64 / GH200 [CI/Build] simplify Dockerfile build for ARM64 / GH200 Dec 16, 2024
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 16, 2024
@youkaichao
Copy link
Member

@cennn thanks for the great work!

@youkaichao youkaichao merged commit b3b1526 into vllm-project:main Dec 16, 2024
87 of 89 checks passed
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
…ject#11212)

Signed-off-by: drikster80 <ed.sealing@gmail.com>
Co-authored-by: drikster80 <ed.sealing@gmail.com>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
…ject#11212)

Signed-off-by: drikster80 <ed.sealing@gmail.com>
Co-authored-by: drikster80 <ed.sealing@gmail.com>
joennlae pushed a commit to 44ai-labs/vllm that referenced this pull request Jan 19, 2025
…ject#11212)

Signed-off-by: drikster80 <ed.sealing@gmail.com>
Co-authored-by: drikster80 <ed.sealing@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants