-
-
Notifications
You must be signed in to change notification settings - Fork 5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Support Cohere2ForCausalLM (Cohere R7B) #11203
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Could you point to the place where rotary embedding is disabled in v2? Looking at the HF implementation, I don't see why it should be disabled when sliding window is active. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding support for this!
Please resolve the failing test. |
Head branch was pushed to by a user without write access
I've added the model to the test list, but wonder if it's a problem if this arch is only in the unreleased version of transformers. |
Can you update |
@@ -11,6 +12,9 @@ | |||
@pytest.mark.parametrize("model_arch", HF_EXAMPLE_MODELS.get_supported_archs()) | |||
def test_can_initialize(model_arch): | |||
model_info = HF_EXAMPLE_MODELS.get_hf_info(model_arch) | |||
if (model_arch == "Cohere2ForCausalLM" | |||
and transformers.__version__ < "4.48.0"): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The model is only available in transformers v4.48 which has not been released yet.
Sliding window support as done in HuggingFace Transformers (>= 4.48.0.dev0) for the Cohere2ForCausalLM arch.