Skip to content

[DO NOT MERGE] VLM offline benchmark with MMMU-Pro vision #11196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 11 commits into from

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 14, 2024

Opened this PR to share the mini offline batch inference benchmark with MMMU-Pro vision.

We may iterate on this and add support for other frameworks for comparison purposes.

Co-authored-by: Cody Yu <comaniac0422@gmail.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
@comaniac
Copy link
Collaborator

comaniac commented Dec 16, 2024

Found that asyncio doesn't work because both initialize_llm and sample_hf_requests are blocking. Add to_thread to create async coroutine to really overlap them. Here is the initialization time before and after the commit (with 350 unique images):
Before: 130s
After: 73s

ywang96 and others added 4 commits December 17, 2024 02:07
Signed-off-by: Roger Wang <ywang@roblox.com>
Signed-off-by: Roger Wang <ywang@roblox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants