[Bugfix][V1] Re-compute an entire block when fully cache hit #11186
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously we re-compute the last token when the prompt is fully cache hit. However, since
allocate_slots()
calculates number of computed tokens based on the number of computed blocks, the number of computed tokensallocate_slots()
inferred is always multiply by the block size. This results in the last block fails to be cached in the right way, and breaks the hash block chain in prefix caching. While this doesn't affect the accuracy, it hurts the cache hit rate a bit.cc @WoosukKwon