Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix][V1] Re-compute an entire block when fully cache hit #11186

Merged
merged 1 commit into from
Dec 14, 2024

Conversation

comaniac
Copy link
Collaborator

@comaniac comaniac commented Dec 13, 2024

Previously we re-compute the last token when the prompt is fully cache hit. However, since allocate_slots() calculates number of computed tokens based on the number of computed blocks, the number of computed tokens allocate_slots() inferred is always multiply by the block size. This results in the last block fails to be cached in the right way, and breaks the hash block chain in prefix caching. While this doesn't affect the accuracy, it hurts the cache hit rate a bit.

cc @WoosukKwon

Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

Signed-off-by: Cody Yu <hao.yu.cody@gmail.com>
Copy link
Collaborator

@WoosukKwon WoosukKwon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for the fix!

@WoosukKwon WoosukKwon merged commit 9855aea into vllm-project:main Dec 14, 2024
23 checks passed
@comaniac comaniac deleted the v1-fix-full-cache branch December 14, 2024 01:19
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants