Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc] Add tokenizer_mode param to benchmark_serving.py #11174

Merged
merged 1 commit into from
Dec 13, 2024
Merged

[Misc] Add tokenizer_mode param to benchmark_serving.py #11174

merged 1 commit into from
Dec 13, 2024

Conversation

alexm-redhat
Copy link
Collaborator

@alexm-redhat alexm-redhat commented Dec 13, 2024 •
edited by github-actions bot
Loading

This is a small PR to add tokenizer_mode param to benchmark_serving.py.

Example execution results are here:
https://docs.google.com/spreadsheets/d/1biWEgyAyZ-WLis6KcyyNASfsLrsUSNNg2_wLpC6-4Hg/edit?usp=sharing

@alexm-redhat alexm-redhat self-assigned this Dec 13, 2024
@alexm-redhat
Copy link
Collaborator Author

/ready

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@alexm-redhat
[benchmark] Add tokenizer_mode param to benchmark_serving.py
1096775 
Signed-off-by: Alexander Matveev <alexm@neuralmagic.com>
DarkLight1337
DarkLight1337 approved these changes Dec 13, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding this!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 13, 2024 14:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 13, 2024
@DarkLight1337 DarkLight1337 merged commit 238c0d9 into main Dec 13, 2024
49 checks passed
@DarkLight1337 DarkLight1337 deleted the bench_tokenizer_mode branch December 13, 2024 16:19
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@alexm-redhat @BKitor
[Misc] Add tokenizer_mode param to benchmark_serving.py (vllm-project…
78cbe23 
…#11174)

Signed-off-by: Alexander Matveev <alexm@neuralmagic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@ywang96 ywang96 Awaiting requested review from ywang96

@comaniac comaniac Awaiting requested review from comaniac

@Isotr0py Isotr0py Awaiting requested review from Isotr0py

Assignees

@alexm-redhat alexm-redhat

Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@alexm-redhat @DarkLight1337