Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Misc][LoRA] Ensure Lora Adapter requests return adapter name #11094

Merged
merged 4 commits into from
Dec 12, 2024
Merged

[Misc][LoRA] Ensure Lora Adapter requests return adapter name #11094

merged 4 commits into from
Dec 12, 2024

Conversation

Jeffwan
Copy link
Contributor

@Jeffwan Jeffwan commented Dec 11, 2024 •
edited by github-actions bot
Loading

FIX #11090

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the frontend label Dec 11, 2024
@Jeffwan Jeffwan force-pushed the jiaxin/lora-name-in-response branch from f7b221c to 29436a5 Compare December 11, 2024 10:03
Jeffwan and others added 2 commits December 11, 2024 12:54
@Jeffwan
Ensure Lora Adapter Requests Return Lora Model Name Instead of Base M…
3cf9e81 
…odel

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@jeejeelee @Jeffwan
Update vllm/entrypoints/openai/serving_engine.py
e6cf13c 
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@Jeffwan Jeffwan force-pushed the jiaxin/lora-name-in-response branch from caa1f9a to e6cf13c Compare December 11, 2024 20:54
@jeejeelee
Copy link
Collaborator

Could you plz add unit test for this, thanks

@Jeffwan
Copy link
Contributor Author

Jeffwan commented Dec 12, 2024

@jeejeelee I can add some unit test for _get_model_name . for model name change in the create_completion part, do you have any suggestion on how to test them? If you can share some related test files, that would be great!

@jeejeelee
Add unit test
eb42ffd 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
jeejeelee
jeejeelee approved these changes Dec 12, 2024
View reviewed changes
Copy link
Collaborator

@jeejeelee jeejeelee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution

@jeejeelee jeejeelee changed the title Ensure Lora Adapter requests return adapter name [Misc][LoRA] Ensure Lora Adapter requests return adapter name Dec 12, 2024
@jeejeelee
format
257a1c0 
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee enabled auto-merge (squash) December 12, 2024 07:30
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 12, 2024
@jeejeelee jeejeelee merged commit 85362f0 into vllm-project:main Dec 12, 2024
63 checks passed
Akshat-Tripathi pushed a commit to krai/vllm that referenced this pull request Dec 12, 2024
@Jeffwan @jeejeelee @Akshat-Tripathi
[Misc][LoRA] Ensure Lora Adapter requests return adapter name (vllm-p…
59d5e84 
…roject#11094)

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Akshat Tripathi <akshat@krai.ai>
@Jeffwan Jeffwan deleted the jiaxin/lora-name-in-response branch December 12, 2024 11:43
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@Jeffwan @jeejeelee
[Misc][LoRA] Ensure Lora Adapter requests return adapter name (vllm-p…
0504d5b 
…roject#11094)

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@Jeffwan @jeejeelee @BKitor
[Misc][LoRA] Ensure Lora Adapter requests return adapter name (vllm-p…
639bd22 
…roject#11094)

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Co-authored-by: Jee Jee Li <pandaleefree@gmail.com>
@jeejeelee jeejeelee mentioned this pull request Jan 8, 2025
Open
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeejeelee jeejeelee jeejeelee approved these changes

@DarkLight1337 DarkLight1337 Awaiting requested review from DarkLight1337 DarkLight1337 is a code owner

@robertgshaw2-redhat robertgshaw2-redhat Awaiting requested review from robertgshaw2-redhat robertgshaw2-redhat is a code owner

@simon-mo simon-mo Awaiting requested review from simon-mo simon-mo is a code owner

Assignees
No one assigned
Labels
frontend ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: lora adapter request still return the base model name
2 participants
@Jeffwan @jeejeelee