Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[V1] Fix Detokenizer loading in AsyncLLM #10997

Merged
merged 1 commit into from
Dec 9, 2024
Merged

[V1] Fix Detokenizer loading in AsyncLLM #10997

merged 1 commit into from
Dec 9, 2024

Conversation

ywang96
Copy link
Member

@ywang96 ywang96 commented Dec 9, 2024

Follow up of #10288 to add missing configs for loading Detokenizer in AsyncLLM for online serving.

@ywang96
fix detok
c299d58 
Signed-off-by: Roger Wang <ywang@roblox.com>
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 9, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@robertgshaw2-redhat robertgshaw2-redhat enabled auto-merge (squash) December 9, 2024 01:28
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 9, 2024
DarkLight1337
DarkLight1337 approved these changes Dec 9, 2024
View reviewed changes
Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing!

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 9, 2024 09:27
@DarkLight1337 DarkLight1337 merged commit c690357 into vllm-project:main Dec 9, 2024
61 of 64 checks passed
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@ywang96
[V1] Fix Detokenizer loading in AsyncLLM (vllm-project#10997)
2f08836 
Signed-off-by: Roger Wang <ywang@roblox.com>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
@ywang96 @BKitor
[V1] Fix Detokenizer loading in AsyncLLM (vllm-project#10997)
adf2060 
Signed-off-by: Roger Wang <ywang@roblox.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertgshaw2-redhat robertgshaw2-redhat robertgshaw2-redhat approved these changes

@DarkLight1337 DarkLight1337 DarkLight1337 approved these changes

@mgoin mgoin mgoin approved these changes

@WoosukKwon WoosukKwon Awaiting requested review from WoosukKwon WoosukKwon is a code owner

@njhill njhill Awaiting requested review from njhill njhill is a code owner

@comaniac comaniac Awaiting requested review from comaniac comaniac is a code owner

@alexm-redhat alexm-redhat Awaiting requested review from alexm-redhat alexm-redhat is a code owner

Assignees
No one assigned
Labels
ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ywang96 @mgoin @DarkLight1337 @robertgshaw2-redhat