Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI/Build] Update mistral_common version for tests and docs #10825

Merged

Conversation

DarkLight1337
Copy link
Member

@DarkLight1337 DarkLight1337 commented Dec 2, 2024

#10367 updated mistral_common only in requirements-common.txt. To maintain consistency, this PR updates it for the other files as well.

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 added the ready ONLY add when PR is ready to merge/full CI is needed label Dec 2, 2024
Copy link

github-actions bot commented Dec 2, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@DarkLight1337 DarkLight1337 changed the title [CI/Build] Update mistral_common version in tests and docs [CI/Build] Update mistral_common version for tests and docs Dec 2, 2024
@mergify mergify bot added the documentation Improvements or additions to documentation label Dec 2, 2024
@DarkLight1337
Copy link
Member Author

DarkLight1337 commented Dec 2, 2024

Wait, let me update the pip-compiled file as well Done

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
@DarkLight1337 DarkLight1337 enabled auto-merge (squash) December 2, 2024 08:42
@mergify mergify bot added the ci/build label Dec 2, 2024
@DarkLight1337 DarkLight1337 merged commit e95f275 into vllm-project:main Dec 2, 2024
66 of 67 checks passed
@DarkLight1337 DarkLight1337 deleted the update-mistral-common branch December 2, 2024 11:06
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
…roject#10825)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: Andrew Feldman <afeldman@neuralmagic.com>
dtrifiro pushed a commit to opendatahub-io/vllm that referenced this pull request Dec 4, 2024
…roject#10825)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
…roject#10825)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
…roject#10825)

Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants