-
-
Notifications
You must be signed in to change notification settings - Fork 5.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Model] Implement merged input processor for LLaVA model #10676
Conversation
…ceholders` Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
@DarkLight1337 What does |
Inside
|
Other models may have additional keys associated with the image modality, so we can't really hardcode this. |
I see where the problem is. Can you see if this model works on V1? |
It still fails because of the hardcoded |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Ok, the test now passes for V1. |
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
a45e7a8
to
a5e4834
Compare
I have updated |
a5e4834
to
1ba6df2
Compare
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
1ba6df2
to
09618d0
Compare
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
…acements` Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR actually seems to break Pixtral HF (I cannot run the example file on v0), so I'm blocking it for now until we fix it.
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
…llm-project#10676) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Co-authored-by: Roger Wang <ywang@roblox.com>
…llm-project#10676) Signed-off-by: DarkLight1337 <tlleungac@connect.ust.hk> Co-authored-by: Roger Wang <ywang@roblox.com>
Part of #10114
This PR completes the basic support for merged input processor. In particular:
MultiModalProcessor
to generate dummy data for profiling. The default implementation uses the placeholder tokens defined in its metadata.PlaceholderMap
and V1MMInputMapper
to handle the outputs ofMultiModalProcessor
.MultiModalRegistry.register_processor_by_metadata
convenience function.With these changes, the merged input processor can now be used for LLaVA model. Other models will be updated in subsequent PRs.