Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ci] add vllm_test_utils #10659

Merged
merged 3 commits into from
Nov 26, 2024
Merged

[ci] add vllm_test_utils #10659

merged 3 commits into from
Nov 26, 2024

Conversation

youkaichao
Copy link
Member

@youkaichao youkaichao commented Nov 26, 2024

some test scripts cannot import vllm, but they need to be reused.

we only install it in test environments.

Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: youkaichao <youkaichao@gmail.com>
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the ci/build label Nov 26, 2024
@youkaichao
Copy link
Member Author

there are also some functions repeated in the tests, like distributed_run:

def distributed_run(fn, world_size):

I'd like to gather them into vllm_test_utils so that #10502 can use it.

Copy link
Member

@DarkLight1337 DarkLight1337 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks reasonable to me.

@DarkLight1337 DarkLight1337 enabled auto-merge (squash) November 26, 2024 06:13
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 26, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
@youkaichao youkaichao merged commit 334d64d into vllm-project:main Nov 26, 2024
68 of 70 checks passed
@youkaichao youkaichao deleted the vllm_utils branch November 26, 2024 08:20
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Nov 26, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Andrew Feldman <afeld2012@gmail.com>
afeldman-nm pushed a commit to neuralmagic/vllm that referenced this pull request Dec 2, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
Signed-off-by: Andrew Feldman <afeldman@neuralmagic.com>
markmc added a commit to markmc/vllm that referenced this pull request Dec 3, 2024
Since vllm-project#10659 (commit 334d64d), you need to install the
`vllm_test_utils` package before running the unit tests.

Signed-off-by: Mark McLoughlin <markmc@redhat.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
BKitor pushed a commit to BKitor/vllm that referenced this pull request Dec 30, 2024
Signed-off-by: youkaichao <youkaichao@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci/build ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants