Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add small example to metrics.rst #10550

Merged
merged 1 commit into from
Nov 21, 2024
Merged

Add small example to metrics.rst #10550

merged 1 commit into from
Nov 21, 2024

Conversation

mgoin
Copy link
Member

@mgoin mgoin commented Nov 21, 2024 •
edited by github-actions bot
Loading

No description provided.

@github-actions GitHub Actions
Copy link

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 21, 2024
@simon-mo simon-mo enabled auto-merge (squash) November 21, 2024 20:27
@github-actions github-actions bot added the ready ONLY add when PR is ready to merge/full CI is needed label Nov 21, 2024
@simon-mo simon-mo merged commit 9afa014 into main Nov 21, 2024
44 of 47 checks passed
@simon-mo simon-mo deleted the metrics-example branch November 21, 2024 23:43
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
@mgoin @tlrmchlsmth
Add small example to metrics.rst (vllm-project#10550)
3bd983f 
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 28, 2024
@mgoin @mfournioux
Add small example to metrics.rst (vllm-project#10550)
3496e9b 
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
@mgoin
Add small example to metrics.rst (vllm-project#10550)
b1689e7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simon-mo simon-mo simon-mo approved these changes

Assignees
No one assigned
Labels
documentation Improvements or additions to documentation ready ONLY add when PR is ready to merge/full CI is needed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mgoin @simon-mo