Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Misc] Improve Web UI #10090

Merged
merged 1 commit into from
Nov 8, 2024
Merged

[Misc] Improve Web UI #10090

merged 1 commit into from
Nov 8, 2024

Conversation

rafvasq
Copy link
Contributor

@rafvasq rafvasq commented Nov 6, 2024

The "ask AI" button overlaps the doc version selection on the web documentation.

Fixes #10089

Copy link

github-actions bot commented Nov 6, 2024

👋 Hi! Thank you for contributing to the vLLM project.
Just a reminder: PRs would not trigger full CI run by default. Instead, it would only run fastcheck CI which starts running only a small and essential subset of CI tests to quickly catch errors. You can run other CI tests on top of those by going to your fastcheck build on Buildkite UI (linked in the PR checks section) and unblock them. If you do not have permission to unblock, ping simon-mo or khluu to add you in our Buildkite org.

Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging.

To run CI, PR reviewers can do one of these:

  • Add ready label to the PR
  • Enable auto-merge.

🚀

@mergify mergify bot added the documentation Improvements or additions to documentation label Nov 6, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@@ -8,7 +8,7 @@ document.addEventListener("DOMContentLoaded", function () {
script.setAttribute("version", "stable");
script.setAttribute("runllm-keyboard-shortcut", "Mod+j"); // cmd-j or ctrl-j to open the widget.
script.setAttribute("runllm-name", "vLLM");
script.setAttribute("runllm-position", "BOTTOM_RIGHT");
script.setAttribute("runllm-position", "BOTTOM_LEFT");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can you keep this and set the version selector in the left?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After reverting and looking into this, I took the conversation back to the issue: #10089 (comment) because I think it's worth discussing a bit more

@youkaichao
Copy link
Member

please fix the documentation build.

@rafvasq rafvasq force-pushed the fix-ui branch 2 times, most recently from 6678039 to f447602 Compare November 8, 2024 17:28
Copy link
Member

@youkaichao youkaichao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the great work!

@youkaichao youkaichao merged commit 6b30471 into vllm-project:main Nov 8, 2024
20 checks passed
@DarkLight1337
Copy link
Member

Hmm... I now find the Ask AI button clipping into the left navigation bar. I prefer placing this near the top right of the screen.

@youkaichao
Copy link
Member

Hmm... I now find the Ask AI button clipping into the left navigation bar. I prefer placing this near the top right of the screen.

replacement is welcome, as long as it does not overlap with the version selector.

JC1DA pushed a commit to JC1DA/vllm that referenced this pull request Nov 11, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
jeejeelee pushed a commit to jeejeelee/vllm that referenced this pull request Nov 11, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
@rafvasq rafvasq deleted the fix-ui branch November 13, 2024 20:58
rickyyx pushed a commit to rickyyx/vllm that referenced this pull request Nov 13, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
sumitd2 pushed a commit to sumitd2/vllm that referenced this pull request Nov 14, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
KuntaiDu pushed a commit to KuntaiDu/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
mfournioux pushed a commit to mfournioux/vllm that referenced this pull request Nov 20, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
tlrmchlsmth pushed a commit to neuralmagic/vllm that referenced this pull request Nov 23, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
sleepwalker2017 pushed a commit to sleepwalker2017/vllm that referenced this pull request Dec 13, 2024
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[help wanted]: website ui improvement
3 participants