-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Misc] Improve Web UI #10090
[Misc] Improve Web UI #10090
Conversation
👋 Hi! Thank you for contributing to the vLLM project. Once the PR is approved and ready to go, your PR reviewer(s) can run CI to test the changes comprehensively before merging. To run CI, PR reviewers can do one of these:
🚀 |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
@@ -8,7 +8,7 @@ document.addEventListener("DOMContentLoaded", function () { | |||
script.setAttribute("version", "stable"); | |||
script.setAttribute("runllm-keyboard-shortcut", "Mod+j"); // cmd-j or ctrl-j to open the widget. | |||
script.setAttribute("runllm-name", "vLLM"); | |||
script.setAttribute("runllm-position", "BOTTOM_RIGHT"); | |||
script.setAttribute("runllm-position", "BOTTOM_LEFT"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you keep this and set the version selector in the left?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After reverting and looking into this, I took the conversation back to the issue: #10089 (comment) because I think it's worth discussing a bit more
please fix the documentation build. |
6678039
to
f447602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks for the great work!
Hmm... I now find the Ask AI button clipping into the left navigation bar. I prefer placing this near the top right of the screen. |
replacement is welcome, as long as it does not overlap with the version selector. |
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Loc Huynh <jc1da.3011@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Jee Jee Li <pandaleefree@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Sumit Dubey <sumit.dubey2@ibm.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Maxime Fournioux <55544262+mfournioux@users.noreply.github.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com> Signed-off-by: Tyler Michael Smith <tyler@neuralmagic.com>
Signed-off-by: Rafael Vasquez <rafvasq21@gmail.com>
The "ask AI" button overlaps the doc version selection on the web documentation.
Fixes #10089