Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]: expose the tqdm progress bar to enable logging the progress #6154

Open
hugolytics opened this issue Jul 5, 2024 · 3 comments · May be fixed by #5774
Open

[Feature]: expose the tqdm progress bar to enable logging the progress #6154

hugolytics opened this issue Jul 5, 2024 · 3 comments · May be fixed by #5774

Comments

@hugolytics
Copy link

🚀 The feature, motivation and pitch

I am running vLLM on aws batch on large datasets and would like to see the progress of the jobs, this is currently not possible.
however tqdm-loggable does enable this, but then I would need to swap the tqdm driver in the llm_engine, this is however not exposed.
so my request would be either to move to tqdm-loggable since it automatically switches given a interactive vs non-interactive environment. Or expose tqdm such that the user can swap it themselves.

Alternatives

No response

Additional context

No response

@w013nad
Copy link

w013nad commented Jul 5, 2024

I have a PR I need to finalize that should do this.

#5774

Copy link

This issue has been automatically marked as stale because it has not had any activity within 90 days. It will be automatically closed if no further activity occurs within 30 days. Leave a comment if you feel this issue should remain open. Thank you!

@sethkimmel3
Copy link
Contributor

Hey @hugolytics - proposing this PR to accomplish the same thing via a state callback method: #9780.

@github-actions github-actions bot added unstale and removed stale labels Nov 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants