Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for sampler #108

Closed
WoosukKwon opened this issue May 18, 2023 · 1 comment
Closed

Add tests for sampler #108

WoosukKwon opened this issue May 18, 2023 · 1 comment
Labels

Comments

@WoosukKwon
Copy link
Collaborator

No description provided.

@hmellor
Copy link
Collaborator

hmellor commented Mar 6, 2024

Closing as samplers now have tests https://github.com/vllm-project/vllm/tree/main/tests/samplers

@hmellor hmellor closed this as completed Mar 6, 2024
yukavio pushed a commit to yukavio/vllm that referenced this issue Jul 3, 2024
SUMMARY:
* upstream merge (sync) up to `657061fdced8a33a60c1b09f5da2525de9da8f03`
* some minor changes related to `ruff` and `yapf`

NOTES: we are now consistently getting out memory of errors when running
`tests/models/test_marlin.py`. i've disabled the test and created an
ASANA ticket to track the issue.

TEST PLAN:
runs on remote push

---------

Signed-off-by: Tao He <sighingnow@gmail.com>
Signed-off-by: Yuan Tang <terrytangyuan@gmail.com>
Co-authored-by: Ronen Schaffer <ronen.schaffer@ibm.com>
Co-authored-by: Mustafa Eyceoz <maxusmusti@gmail.com>
Co-authored-by: Roy <jasonailu87@gmail.com>
Co-authored-by: Woosuk Kwon <woosuk.kwon@berkeley.edu>
Co-authored-by: Massimiliano Pronesti <massimiliano.pronesti@gmail.com>
Co-authored-by: 44670 <44670@users.noreply.github.com>
Co-authored-by: zhaoyang-star <zhaoyangstar@foxmail.com>
Co-authored-by: Harry Mellor <19981378+hmellor@users.noreply.github.com>
Co-authored-by: Jared Moore <27744679+jlcmoore@users.noreply.github.com>
Co-authored-by: Philipp Moritz <pcmoritz@gmail.com>
Co-authored-by: Cade Daniel <edacih@gmail.com>
Co-authored-by: 张大成 <1345739055@qq.com>
Co-authored-by: zhangdacheng <zhangdacheng@ainirobot.com>
Co-authored-by: Jingru <niejingru@hotmail.com>
Co-authored-by: Dylan Hawk <51147702+dylanwhawk@users.noreply.github.com>
Co-authored-by: Tao He <sighingnow@gmail.com>
Co-authored-by: Ganesh Jagadeesan <ganesh.jcs@gmail.com>
Co-authored-by: Allen.Dou <allen.dou@hotmail.com>
Co-authored-by: Liangfu Chen <liangfc@amazon.com>
Co-authored-by: CHU Tianxiang <tianxiang.ctx@alibaba-inc.com>
Co-authored-by: Jae-Won Chung <jwnchung@umich.edu>
Co-authored-by: Seonghyeon <seonghyeon.drew@gmail.com>
Co-authored-by: Billy Cao <aliencaocao@gmail.com>
Co-authored-by: Nick Hill <nickhill@us.ibm.com>
Co-authored-by: felixzhu555 <79335195+felixzhu555@users.noreply.github.com>
Co-authored-by: br3no <breno@veltefaria.de>
Co-authored-by: simon-mo <simon.mo@hey.com>
Co-authored-by: Sherry <503147114@qq.com>
Co-authored-by: Yuan Tang <terrytangyuan@gmail.com>
Co-authored-by: Huarong <huohuarong@gmail.com>
Co-authored-by: huohuarong <huohuarong@zuoshouyisheng.com>
Co-authored-by: Robert Shaw <114415538+robertgshaw2-neuralmagic@users.noreply.github.com>
Co-authored-by: Robert Shaw <114415538+rib-2@users.noreply.github.com>
Co-authored-by: alexm <alexm@neuralmagic.com>
Co-authored-by: zixiao <shunli.dsl@alibaba-inc.com>
Co-authored-by: cloudhan <cloudhan@outlook.com>
Co-authored-by: Sage Moore <sagemoore@utexas.edu>
Co-authored-by: ElizaWszola <eliza@neuralmagic.com>
Co-authored-by: Michael Goin <michael@neuralmagic.com>
Co-authored-by: Jason Cox <jason@jasonacox.com>
Co-authored-by: Zhuohan Li <zhuohan123@gmail.com>
Co-authored-by: Roger Wang <136131678+ywang96@users.noreply.github.com>
Co-authored-by: TianYu GUO <guoty9@mail2.sysu.edu.cn>
Co-authored-by: Jialun Lyu <43287111+pian13131@users.noreply.github.com>
Co-authored-by: ttbachyinsda <ttbachyinsda@outlook.com>
Co-authored-by: guofangze <guofangze@kuaishou.com>
Co-authored-by: Antoni Baum <antoni.baum@protonmail.com>
Co-authored-by: Avnish Narayan <avnish@anyscale.com>
Co-authored-by: Chen Wang <Chen.Wang1@ibm.com>
Co-authored-by: Hongxia Yang <62075498+hongxiayang@users.noreply.github.com>
Co-authored-by: lcskrishna <lollachaitanya@gmail.com>
Co-authored-by: SangBin Cho <rkooo567@gmail.com>
Co-authored-by: Chujie Zheng <chujiezhengchn@gmail.com>
Co-authored-by: TechxGenus <jianghao0728@mail.ustc.edu.cn>
Co-authored-by: Michael Goin <mgoin64@gmail.com>
Co-authored-by: jacobthebanana <50071502+jacobthebanana@users.noreply.github.com>
Co-authored-by: whyiug <whyiug@hotmail.com>
Co-authored-by: Terry <149540247+tterrysun@users.noreply.github.com>
Co-authored-by: Douglas Lehr <91553416+dllehr-amd@users.noreply.github.com>
Co-authored-by: andy-neuma <andy@neuralmagic.com>
mht-sharma pushed a commit to mht-sharma/vllm that referenced this issue Aug 1, 2024
…#108)

This change has the unintended side effect of making sure Paged Attention V1 is never called in graph mode. The correct fix would bring the decode kernel selection before the graph capture point but this necessitates a huge refactor.
Xaenalt pushed a commit to Xaenalt/vllm that referenced this issue Aug 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants