Skip to content

Fix after #16229, mm #286

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Oct 1, 2025
Merged

Fix after #16229, mm #286

merged 12 commits into from
Oct 1, 2025

Conversation

@adobrzyn
Copy link
Collaborator

@adobrzyn adobrzyn commented Sep 29, 2025 •
edited by xuechendi
Loading

upstream PR: vllm-project/vllm#16229
Fix is still in progress, don't merge yet

@github-actions
Copy link

github-actions bot commented Sep 29, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@adobrzyn adobrzyn changed the title [Hourly Fix] Fix [FIX-FOR-VLLM-LATEST] Fix Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

This is a Draft PR. Please mark it as 'Ready for Review' to trigger the CI.

@adobrzyn adobrzyn marked this pull request as ready for review September 29, 2025 08:04
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

The DCO sign-off check did not pass (status: action_required). Please ensure all commits are signed-off.

@kzawora-intel kzawora-intel changed the title [FIX-FOR-VLLM-LATEST] Fix [FIX_FOR_VLLM_LATEST] Fix Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 29, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

The DCO sign-off check did not pass (status: action_required). Please ensure all commits are signed-off.

@adobrzyn adobrzyn changed the title [FIX_FOR_VLLM_LATEST] Fix [FIX_FOR_VLLM_LATEST] Fix after #16229, mm Sep 29, 2025
@github-actions
Copy link

github-actions bot commented Sep 30, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

Your branch is behind the base branch. Please merge or rebase to get the latest changes.

adobrzyn and others added 10 commits October 1, 2025 01:23
@adobrzyn @xuechendi
Fix after #16229
572137b 
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@adobrzyn @xuechendi
Aaa
a70d18a 
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@adobrzyn @xuechendi
indent bad
9531fbc 
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@adobrzyn @xuechendi
:/
26ca7bc 
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@adobrzyn @xuechendi
Update hpu_model_runner.py
8a7016e
@adobrzyn @xuechendi
....
5d34534 
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@adobrzyn @xuechendi
Update hpu_model_runner.py
02365cf
@adobrzyn @xuechendi
This should work
f0a6987 
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@adobrzyn @xuechendi
Update hpu_model_runner.py
5692598
@adobrzyn @xuechendi
:(
9816ee2 
Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
@xuechendi xuechendi changed the title [FIX_FOR_VLLM_LATEST] Fix after #16229, mm Fix after #16229, mm Oct 1, 2025
@xuechendi
Fix shape issue
5ed3255 
Signed-off-by: Chendi Xue <Chendi.Xue@intel.com>
@xuechendi xuechendi force-pushed the adobrzyn/hourly_fix_sep27 branch from bdfb918 to 5ed3255 Compare October 1, 2025 02:01
@github-actions
Copy link

github-actions bot commented Oct 1, 2025

🚧 CI Blocked

The main CI workflow was not started for the following reason:

Your branch is behind the base branch. Please merge or rebase to get the latest changes.

@github-actions
Copy link

github-actions bot commented Oct 1, 2025

✅ CI Passed

All checks passed successfully against the following vllm commit:
96ebcaa3ad7b09dfb911bee9a8e904612868b12c

@xuechendi xuechendi merged commit 18ead2d into main Oct 1, 2025
35 checks passed
iboiko-habana pushed a commit to iboiko-habana/vllm-gaudi that referenced this pull request Oct 2, 2025
@adobrzyn @xuechendi @iboiko-habana
Fix after #16229, mm (vllm-project#286)
a0f865f 
upstream PR: vllm-project/vllm#16229
Fix is still in progress, don't merge yet

---------

Signed-off-by: Agata Dobrzyniewicz <adobrzyniewicz@habana.ai>
Signed-off-by: Chendi Xue <Chendi.Xue@intel.com>
Co-authored-by: Chendi Xue <Chendi.Xue@intel.com>
Signed-off-by: Iryna Boiko <iboiko@habana.ai>
@xuechendi xuechendi mentioned this pull request Oct 2, 2025
Closed
xuechendi added a commit that referenced this pull request Oct 3, 2025
@xuechendi
Revert "Fix after #16229, mm (#286)"
729c109 
This reverts commit 18ead2d.
xuechendi added a commit that referenced this pull request Oct 3, 2025
@xuechendi
Revert "Fix after #16229, mm (#286)"
f88ff73 
This reverts commit 18ead2d.
@adobrzyn adobrzyn deleted the adobrzyn/hourly_fix_sep27 branch October 13, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xuechendi xuechendi xuechendi approved these changes

@kzawora-intel kzawora-intel Awaiting requested review from kzawora-intel kzawora-intel is a code owner

@mswiniarsk mswiniarsk Awaiting requested review from mswiniarsk mswiniarsk is a code owner

@mgawarkiewicz-intel mgawarkiewicz-intel Awaiting requested review from mgawarkiewicz-intel mgawarkiewicz-intel is a code owner

@vivekgoe vivekgoe Awaiting requested review from vivekgoe vivekgoe is a code owner

@afierka-intel afierka-intel Awaiting requested review from afierka-intel afierka-intel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adobrzyn @xuechendi