Skip to content

Conversation

@Potabk
Copy link
Collaborator

@Potabk Potabk commented Dec 2, 2025

What this PR does / why we need it?

Do not limit transformers version any more, follow what vllm use instead, see vllm-project/vllm#29841

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: wangli <wangli858794774@gmail.com>
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request aims to remove the version limit for the transformers package. However, the current changes remove the dependency entirely from pyproject.toml and requirements.txt instead of just removing the version constraint. This is likely incorrect, as vllm-ascend is expected to have a direct dependency on transformers. Relying on it as a transitive dependency from vllm is not robust. I've provided suggestions to keep transformers as a dependency while removing the version cap, which aligns with the PR's goal.

@github-actions
Copy link

github-actions bot commented Dec 2, 2025

👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:‌‌

  • A PR should do only one thing, smaller PRs enable faster reviews.
  • Every PR should include unit tests and end-to-end tests ‌to ensure it works and is not broken by other future PRs.
  • Write the commit message by fulfilling the PR description to help reviewer and future developers understand.

If CI fails, you can run linting and testing checks locally according Contributing and Testing.

@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@Potabk Potabk closed this Dec 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant