Skip to content

[CI] Pin transformers<4.53.0 and fix EPLB load_weights to make CI passed #1482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 27, 2025

Conversation

MengqingCao
Copy link
Collaborator

@MengqingCao MengqingCao commented Jun 27, 2025

What this PR does / why we need it?

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

Signed-off-by: MengqingCao <cmq0113@163.com>
Copy link
Collaborator

@Yikun Yikun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI all passed

@Yikun Yikun changed the title [CI] quick fix for deepseek load_weights [CI] Pin transformers<4.53.0 and fix EPLB load_weights to make CI passed Jun 27, 2025
Copy link

codecov bot commented Jun 27, 2025

Codecov Report

Attention: Patch coverage is 8.41121% with 98 lines in your changes missing coverage. Please review.

Project coverage is 31.65%. Comparing base (c30ddb8) to head (6dedd47).
Report is 38 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/models/deepseek_dbo.py 9.25% 49 Missing ⚠️
vllm_ascend/models/deepseek_v2.py 7.54% 49 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1482      +/-   ##
==========================================
+ Coverage   27.39%   31.65%   +4.25%     
==========================================
  Files          56       60       +4     
  Lines        6191     6638     +447     
==========================================
+ Hits         1696     2101     +405     
- Misses       4495     4537      +42     
Flag Coverage Δ
unittests 31.65% <8.41%> (+4.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Signed-off-by: Yikun Jiang <yikunkero@gmail.com>
@Yikun
Copy link
Collaborator

Yikun commented Jun 27, 2025

Cosider we passed all multi card test with no code changes in #1485 to recover CI.

image

[1] https://github.com/vllm-project/vllm-ascend/actions/runs/15929963209/job/44936486165?pr=1485

cc @wangxiyuan @ganyi1996ppo @jianzs

@Yikun Yikun merged commit d59e7fa into vllm-project:main Jun 27, 2025
24 checks passed
@MengqingCao MengqingCao deleted the deepseekci2 branch June 28, 2025 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants