Skip to content

[Core] Fix block table shape to make Prefix cache work with Ascend scheduler #1446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

yiz-liu
Copy link
Contributor

@yiz-liu yiz-liu commented Jun 26, 2025

What this PR does / why we need it?

This fix the shape of block_table which was introduced by hybrid kv groups several weeks ago.

Error will be raised when enable prefix-cache (eager or not) and Ascend Scheduler at the same time, just send two identical requests and it will reproduce.

Does this PR introduce any user-facing change?

How was this patch tested?

Signed-off-by: Yizhou Liu <liu_yizhou@outlook.com>
Copy link

codecov bot commented Jun 26, 2025

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 27.41%. Comparing base (c30ddb8) to head (a37cce9).
Report is 36 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/attention/attention_v1.py 0.00% 2 Missing ⚠️

❌ Your patch check has failed because the patch coverage (0.00%) is below the target coverage (100.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1446      +/-   ##
==========================================
+ Coverage   27.39%   27.41%   +0.01%     
==========================================
  Files          56       56              
  Lines        6191     6271      +80     
==========================================
+ Hits         1696     1719      +23     
- Misses       4495     4552      +57     
Flag Coverage Δ
unittests 27.41% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yikun Yikun changed the title [Fix] Fix block table shape [Core] Fix block table shape to make Prefix cache work with Ascend scheduler Jun 27, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants