[v0.9.1][perf] add a switch for enabling NZ layout in weights and enable NZ for GMM. #1409
+38
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
linfeng-yuan
force-pushed
the
v0.9.1_NZ_switch
branch
5 times, most recently
from
19b283d to
e4689a5
Compare
wangxiyuan
approved these changes
Jun 25, 2025
| @@ -41,6 +41,8 @@ def __init__(self, vllm_config): | |||
| self.expert_map_path = additional_config.get("expert_map_path", None) | |||
| self.chunked_prefill_for_mla = additional_config.get( | |||
| "chunked_prefill_for_mla", False) | |||
| self.enable_weight_nz_layout = additional_config.get( | |||
| "enable_weight_nz_layout", False) | |||
There was a problem hiding this comment.
once when you sync the PR to main, please update additional config doc as well. And if this is a temp config, add TODO here is necessary as well.
There was a problem hiding this comment.
once when you sync the PR to main, please update additional config doc as well. And if this is a temp config, add TODO here is necessary as well.
Sure, thanks for reminding me.
|
commit message should be updated |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: linfeng-yuan <1102311262@qq.com>
linfeng-yuan
force-pushed
the
v0.9.1_NZ_switch
branch
from
e4689a5 to
9fa145c
Compare
Done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
Does this PR introduce any user-facing change?
Users should set
enable_weight_nz_layouttotruein--additional-configwhen they wanna enable weights NZ layout.How was this patch tested?