Skip to content

[MISC] Remove useless patch #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 24, 2025

Conversation

wangxiyuan
Copy link
Collaborator

@wangxiyuan wangxiyuan commented Jun 23, 2025

What this PR does / why we need it?

stateless_init_dp_group in vllm works with non-cuda platform now. Remove this useless patch.

Which was introduced in vllm-ascend by e74331a (v0.8.4rc2)
vLLM upstream merged: vllm-project/vllm@3e472d8 (v0.8.0)

Does this PR introduce any user-facing change?

No

How was this patch tested?

CI passed

Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
@wangxiyuan wangxiyuan force-pushed the remove_ueless_patch branch from 835c8e3 to a332a5c Compare June 23, 2025 09:35
Copy link

codecov bot commented Jun 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.32%. Comparing base (c30ddb8) to head (a332a5c).
Report is 13 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1366      +/-   ##
==========================================
- Coverage   27.39%   27.32%   -0.08%     
==========================================
  Files          56       56              
  Lines        6191     6178      -13     
==========================================
- Hits         1696     1688       -8     
+ Misses       4495     4490       -5     
Flag Coverage Δ
unittests 27.32% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Yikun
Copy link
Collaborator

Yikun commented Jun 24, 2025

This patch was introduced in vllm-ascend by e74331a (v0.8.4rc2)
vLLM upstream merged: vllm-project/vllm@3e472d8 (v0.8.0)

@ganyi1996ppo Could you tell me why we need this patch before? Any special reason here?

@ganyi1996ppo
Copy link
Collaborator

ganyi1996ppo commented Jun 24, 2025

This patch was introduced in vllm-ascend by e74331a (v0.8.4rc2) vLLM upstream merged: vllm-project/vllm@3e472d8 (v0.8.0)

@ganyi1996ppo Could you tell me why we need this patch before? Any special reason here?

Mainly because of that we want to adopt hccl backend on stateless process group, but we don't actually needs this now. I also think this patch should be removed.

@ganyi1996ppo ganyi1996ppo merged commit 9cbce42 into vllm-project:main Jun 24, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants