Skip to content

support fused_moe_allgather_ep #1335

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 23, 2025
Merged

Conversation

lyj-jjj
Copy link
Contributor

@lyj-jjj lyj-jjj commented Jun 21, 2025

What this PR does / why we need it?

support fused_moe_allgather_ep

Does this PR introduce any user-facing change?

--

How was this patch tested?

It was tested by UT.

Signed-off-by: lyj-jjj <liuyingjun5@huawei.com>
Copy link

codecov bot commented Jun 21, 2025

Codecov Report

Attention: Patch coverage is 11.11111% with 40 lines in your changes missing coverage. Please review.

Project coverage is 27.28%. Comparing base (097e714) to head (58cbe53).
Report is 13 commits behind head on main.

Files with missing lines Patch % Lines
vllm_ascend/quantization/w8a8_dynamic.py 8.82% 31 Missing ⚠️
vllm_ascend/ops/fused_moe.py 0.00% 6 Missing ⚠️
vllm_ascend/utils.py 40.00% 3 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1335      +/-   ##
==========================================
- Coverage   27.39%   27.28%   -0.12%     
==========================================
  Files          56       56              
  Lines        6191     6227      +36     
==========================================
+ Hits         1696     1699       +3     
- Misses       4495     4528      +33     
Flag Coverage Δ
unittests 27.28% <11.11%> (-0.12%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jianzs jianzs merged commit 5177bef into vllm-project:main Jun 23, 2025
23 checks passed
"""
Execute the inference of fused_moe_allgather_ep and fused_moe_alltoall_ep.

Run 'pytest tests/multicard/test_fused_moe_allgather_ep.py'.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The test file path was wrong, so the test didn't triggered, pls move this to e2e/multicard.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants