[UT] refactor test_expert_load_balancer and fix broken CI #1293
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wangxiyuan
force-pushed
the
refactor_ut
branch
3 times, most recently
from
04c5f69 to
9fb925b
Compare
wangxiyuan
changed the title
wangxiyuan
force-pushed
the
refactor_ut
branch
5 times, most recently
from
0e2da4c to
b40042f
Compare
Signed-off-by: wangxiyuan <wangxiyuan1007@gmail.com>
Yikun
approved these changes
Jun 19, 2025
|
Merge this to recover CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
refactor test_expert_load_balancer to keep the ut code style
This PR also fixed the break change from https://github.com/vllm-project/vllm/pull/16188/files#diff-e2942ece30a5c580437694ffb964bfc664b510c59244c08e5921b8f5cefb4280
This is just a quick fix. We'll support embedding on V1 later
Closes: #1299