[RpaV3] Renable Tests Part 1 #534
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
QiliangCui
force-pushed
the
rpa3-fix-tests
branch
from
51e50a9 to
abf834f
Compare
QiliangCui
commented
Aug 21, 2025
| def generate_kv_caches(num_kv_heads, head_size, mesh, dtype): | ||
| cache_shape = get_kv_cache_shape_with_mesh(mesh, 1024, 16, num_kv_heads, | ||
| head_size, dtype) | ||
| head_size, t2j_dtype(dtype)) |
There was a problem hiding this comment.
the dtype change looks good to me
QiliangCui
commented
Aug 21, 2025
| ref_output, _ = ref_ragged_paged_attention( | ||
| q, | ||
| jax.device_put(t2j(k), NamedSharding(mesh, P())), | ||
| jax.device_put(t2j(v), NamedSharding(mesh, P())), |
There was a problem hiding this comment.
added this to avoid complaining "device mismatch". @bythew3i
wwl2755-google
approved these changes
Aug 21, 2025
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
QiliangCui
force-pushed
the
rpa3-fix-tests
branch
from
abf834f to
b288d0e
Compare
patemotter
approved these changes
Aug 21, 2025
hfan
approved these changes
Aug 21, 2025
Lumosis
pushed a commit
that referenced
this pull request
Aug 26, 2025
Signed-off-by: Qiliang Cui <derrhein@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Re-enable tests.
Add
tpu_commons/tests/models/vllmback.If the change fixes a bug or a Github issue, please include a link, e.g.,:
FIXES: b/438779127
Tests
Wait for CI Result.
https://buildkite.com/tpu-commons/tpu-commons-ci/builds/2100
https://buildkite.com/tpu-commons/tpu-commons-ci/builds/2116