Skip to content

feat: support PII detection in http request #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Mar 17, 2025

Conversation

rootfs
Copy link
Contributor

@rootfs rootfs commented Mar 5, 2025

FIX #227

This is an initial draft for PII detection. This PR only includes the NLP updates in feature gates. The full router integration can be found here.

At the moment, only PII detection is enabled. I also want to have PII redaction, but it requires router support to rewrite HTTP header.

The demo can be found:

asciicast

cc @ApostaC @YuhanLiu11 @Shaoting-Feng

@rootfs rootfs marked this pull request as draft March 5, 2025 20:31
@rootfs rootfs marked this pull request as ready for review March 14, 2025 21:31
rootfs added 4 commits March 17, 2025 11:16
Signed-off-by: Huamin Chen <hchen@redhat.com>
Signed-off-by: Huamin Chen <hchen@redhat.com>
Signed-off-by: Huamin Chen <hchen@redhat.com>
Signed-off-by: Huamin Chen <hchen@redhat.com>
@rootfs
Copy link
Contributor Author

rootfs commented Mar 17, 2025

@Shaoting-Feng @YuhanLiu11 @ApostaC would it be ok if you review and merge this one first? It only adds to the experimental directory without enabling PII detection. The enablement PR will come next, thanks.

@YuhanLiu11
Copy link
Collaborator

@rootfs sure! We will take a look soon!

Copy link
Collaborator

@YuhanLiu11 YuhanLiu11 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! thanks!

@YuhanLiu11 YuhanLiu11 merged commit 1bd0dfe into vllm-project:main Mar 17, 2025
9 checks passed
JustinDuy pushed a commit to JustinDuy/production-stack-1 that referenced this pull request Jun 13, 2025
* feat: support PII detection in http request

Signed-off-by: Huamin Chen <hchen@redhat.com>

* add regex analyzer

Signed-off-by: Huamin Chen <hchen@redhat.com>

* fix issues reported by pre-commit

Signed-off-by: Huamin Chen <hchen@redhat.com>

* fix pre-commit error

Signed-off-by: Huamin Chen <hchen@redhat.com>

---------

Signed-off-by: Huamin Chen <hchen@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

feature: Detect PII in HTTP request
2 participants