-
Notifications
You must be signed in to change notification settings - Fork 276
Modernize entrypoints module with type hints and use generic types #1965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modernize entrypoints module with type hints and use generic types #1965
Conversation
Summary of ChangesHello @sugatmahanti, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request modernizes the type annotations within the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
|
👋 Hi! Thank you for contributing to llm-compressor. Please add the ready label when the PR is ready for review. Note: This is required to complete the testing suite, please only add the label once the PR is code complete and local testing has been performed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request modernizes the type annotations in the entrypoint modules by using the | operator for unions and built-in generic types like list and dict. The changes are well-executed and improve code readability. I've also noted the typo fixes, which are appreciated. My review includes a couple of suggestions to further improve consistency and clarity, mainly related to ensuring type hints are specific and that docstrings are updated to match the new type hints.
a4ee2fc to
ce130cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small nit, but otherwise LGTM, Thank you for your contribution!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good though you'll need to fix the signoff issue on the commits
@HDCharles I set DCO to pass (you can do this by clicking the three dots -> View details). Will try to land this once transformers tests run |
|
@sugatmahanti Looks like a quick rebase |
|
@kylesayrs Will do that! |
de8a340 to
34b6df6
Compare
49a4dc1
34b6df6 to
49a4dc1
Compare
|
@kylesayrs It is ready for review. Thanks! |
49a4dc1 to
fc900ca
Compare
fc900ca to
d0bb3eb
Compare
|
Thank you so much for reviews, approvals and the merge! |
SUMMARY:
This is part of #1927
Modernize type annotations using | operator and built-in generics in the
entrypoints moduleas part of codebase modernization effort. I also fixed 2 typos as part of this PR.TEST PLAN:
Notes:
Happy to address any comments! Also please let me know if you dont want typos to be fixed as part of this PR. Thank you!