Skip to content

Change default "role" from "system" to "user" #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 10, 2024
Merged

Change default "role" from "system" to "user" #53

merged 2 commits into from
Sep 10, 2024

Conversation

philschmid
Copy link
Contributor

This is a PR for #52. I am not sure if there are other implications but with that change it works for Gemma 2 9b IT.

markurtz
markurtz approved these changes Sep 10, 2024
View reviewed changes
Copy link
Collaborator

@markurtz markurtz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for the contribution @philschmid!

@markurtz markurtz merged commit 1409245 into vllm-project:main Sep 10, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markurtz markurtz markurtz approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@philschmid @markurtz