Skip to content

Sparse attention : Generalize arch checks for A100 and above #73

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 28, 2025

Conversation

ExtReMLapin
Copy link

No description provided.

@ExtReMLapin ExtReMLapin marked this pull request as ready for review July 11, 2025 07:45
@ExtReMLapin
Copy link
Author

Tested on a RTX 5090 with fp8 quantization AND tensor split at 2, working 👍🏻

Copy link
Collaborator

@LucasWilkinson LucasWilkinson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense to me since we build for 8.0+PTX;

can you please just sign off on the commits so the DCO passes

Signed-off-by: CNE FICHEPOIL Pierre <pierre-1.fichepoil@gendarmerie.interieur.gouv.fr>
@ExtReMLapin
Copy link
Author

ExtReMLapin commented Jul 17, 2025

Sorry about the DCO thing, most of my PR are rushed
should be good now

@ExtReMLapin
Copy link
Author

@LucasWilkinson anything else missing ?

@LucasWilkinson LucasWilkinson merged commit 2c87db5 into vllm-project:main Jul 28, 2025
1 check passed
@LucasWilkinson
Copy link
Collaborator

Looks good, thanks for the contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants