vllm_flash_attn: Setup for vllm_kernels package #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author
|
cc @LucasWilkinson for review |
Collaborator
LucasWilkinson
left a comment
LucasWilkinson
left a comment
There was a problem hiding this comment.
would a relative import work here?
i.e. from ..ops.triton.rotary import apply_rotary
Author
Let me try this really quick |
This import was failing when I was attempting to run tests so let's just use relative imports instead of full package imports Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
seemethere
force-pushed
the
seemethere/vllm_kernels
branch
from
8e63f13 to
ac67b26
Compare
Author
Okay this appears to work just fine. |
zyongye
pushed a commit
to zyongye/flash-attention
that referenced
this pull request
Aug 7, 2025
This import was failing when I was attempting to run tests so let's just use relative imports instead of full package imports Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
LucasWilkinson
pushed a commit
that referenced
this pull request
Aug 7, 2025
This import was failing when I was attempting to run tests so let's just use relative imports instead of full package imports Signed-off-by: Eli Uriegas <eliuriegas@meta.com>
jayhshah
pushed a commit
that referenced
this pull request
Aug 8, 2025
This import was failing when I was attempting to run tests so let's just use relative imports instead of full package imports Signed-off-by: Eli Uriegas <eliuriegas@meta.com> Signed-off-by: Jay Shah <jayhshah@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This import was failing when I was attempting to run tests so let's just add a try / except to ensure that this is backwards compatible and we can clean this up after the full vllm_kernels PR lands.
This relates to vllm-project/vllm#17419