Skip to content

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented Mar 6, 2025

Pull Request Description

This is a blocker for release branch testing now. Since we move to fork mode for development, release branch and main branch now are all protected branch. We should enable test against any change on these branches.

Related Issues

Resolves: #804

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@Jeffwan Jeffwan force-pushed the jiaxin/enable-test-on-release-branch branch from d6e39c2 to 7e0dcec Compare March 6, 2025 03:12
Copy link
Collaborator

@kerthcet kerthcet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@Jeffwan Jeffwan changed the title Enable CI test for release branch Enable CI tests for release branch Mar 6, 2025
@Jeffwan Jeffwan merged commit f60bc1b into vllm-project:main Mar 6, 2025
8 checks passed
Jeffwan added a commit to Jeffwan/aibrix that referenced this pull request Mar 6, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Jeffwan added a commit to Jeffwan/aibrix that referenced this pull request Mar 6, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Jeffwan added a commit that referenced this pull request Mar 6, 2025
Enable CI tests for release branch (#805)

Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Jeffwan added a commit that referenced this pull request Mar 6, 2025
Enable CI tests for release branch (#805)

Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
happyandslow pushed a commit to happyandslow/aibrix that referenced this pull request Mar 6, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: Le Xu <le.xu@bytedance.com>
jolfr pushed a commit to jolfr/aibrix that referenced this pull request Mar 7, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: jolfr <thomas.jack.carroll@gmail.com>
jolfr pushed a commit to jolfr/aibrix that referenced this pull request Mar 7, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: jolfr <thomas.jack.carroll@gmail.com>
jolfr pushed a commit to jolfr/aibrix that referenced this pull request Mar 7, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Signed-off-by: jolfr <thomas.jack.carroll@gmail.com>
@Jeffwan Jeffwan deleted the jiaxin/enable-test-on-release-branch branch March 8, 2025 09:36
Jeffwan added a commit to Jeffwan/aibrix that referenced this pull request Mar 9, 2025
This is missing in my earlier PR vllm-project#805 and I make it work on release branch vllm-project#809. Now, we need to make up in the main branch.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Jeffwan added a commit that referenced this pull request Mar 9, 2025
* Fix integration test trigger issue

This is missing in my earlier PR #805 and I make it work on release branch #809. Now, we need to make up in the main branch.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

* Fix some log format issue and remove unnecessary logs

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

---------

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
gangmuk pushed a commit to gangmuk/aibrix-gangmuk that referenced this pull request Jun 21, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
gangmuk pushed a commit to gangmuk/aibrix-gangmuk that referenced this pull request Jun 21, 2025
…#837)

* Fix integration test trigger issue

This is missing in my earlier PR vllm-project#805 and I make it work on release branch vllm-project#809. Now, we need to make up in the main branch.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

* Fix some log format issue and remove unnecessary logs

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

---------

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
Enable tests for release branch

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
…#837)

* Fix integration test trigger issue

This is missing in my earlier PR vllm-project#805 and I make it work on release branch vllm-project#809. Now, we need to make up in the main branch.

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

* Fix some log format issue and remove unnecessary logs

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>

---------

Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tests on release branch are not enabled and it blocks minor version release
2 participants