Skip to content

Conversation

kerthcet
Copy link
Collaborator

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

comment: https://github.com/vllm-project/aibrix/pull/713/files#r1968598195

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@kerthcet
Copy link
Collaborator Author

It's based on #740, let's merge #740 first.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 25, 2025

@kerthcet #740 is merged. Seems the CI is problematic, it doesn't detect the conflicts now. Please help rebase the change

Copy link
Collaborator

@Jeffwan Jeffwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Signed-off-by: kerthcet <kerthcet@gmail.com>
@kerthcet
Copy link
Collaborator Author

@kerthcet #740 is merged. Seems the CI is problematic, it doesn't detect the conflicts now. Please help rebase the change

I cherry-picked the commit, so conflict may not happen. Ready to merge now.

@Jeffwan
Copy link
Collaborator

Jeffwan commented Feb 26, 2025

Sounds good

@Jeffwan Jeffwan merged commit bc03717 into vllm-project:main Feb 26, 2025
11 checks passed
xieus pushed a commit that referenced this pull request Mar 5, 2025
Use native codegen command for client-go

Signed-off-by: kerthcet <kerthcet@gmail.com>
Signed-off-by: Liguang Xie <liguang.vt@gmail.com>
gangmuk pushed a commit to gangmuk/aibrix-gangmuk that referenced this pull request Jun 21, 2025
Use native codegen command for client-go

Signed-off-by: kerthcet <kerthcet@gmail.com>
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
Use native codegen command for client-go

Signed-off-by: kerthcet <kerthcet@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants