Update routers to use GetPodModelMetric api and misc cleanup in metri… #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeffwan
reviewed
Jan 23, 2025
| MODEL_NAME = os.getenv('MODEL_NAME', 'llama2-70b') | ||
| DEPLOYMENT_NAME = os.getenv('DEPLOYMENT_NAME', 'llama2-70b') | ||
| MODEL_NAME = os.getenv('MODEL_NAME', 'llama2-7b') | ||
| DEPLOYMENT_NAME = os.getenv('DEPLOYMENT_NAME', 'llama2-7b') |
There was a problem hiding this comment.
nice catch. name has been changed. We probably can inject from env using reference later.
Jeffwan
reviewed
Jan 23, 2025
development/app/app.py
Outdated
| for metric in simple_metrics: | ||
| metrics_output += generate_counter_gauge_metric(metric["name"], metric["type"], metric["description"], | ||
| model_name, metric["value"]) | ||
| metrics_output += generate_counter_gauge_metric(metric["name"], metric["type"], metric["description"], | ||
| "lora-1", metric["value"], help_header=False) | ||
| "text2sql-lora-1", metric["value"], help_header=False) |
There was a problem hiding this comment.
em. does user register a different name here?
There was a problem hiding this comment.
this is not a blocker for the merge.
There was a problem hiding this comment.
not sure from where lora-1 name came from. I added text2sql lora name based off model adapter.
gangmuk
pushed a commit
to gangmuk/aibrix-gangmuk
that referenced
this pull request
Jun 21, 2025
vllm-project#590) * Update routers to use GetPodModelMetric api and misc cleanup in metrics collection in cache * nit namespace name fix in httproute delete * nit
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
vllm-project#590) * Update routers to use GetPodModelMetric api and misc cleanup in metrics collection in cache * nit namespace name fix in httproute delete * nit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.