[Bug] fix(e2e flaky): replace for-loop with wait.PollUntilContextTimeout in validateAllPodsAreReady

[googs1025]

Pull Request Description

[Please provide a clear and concise description of your changes here]

Replace the for loop in validateAllPodsAreReady with Kubernetes'
wait.PollUntilContextTimeout to improve reliability and readability.

Related Issues

Resolves: #1206

fix: #1206

Important: Before submitting, please complete the description above and review the checklist below.

---

Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

• [Bug]: Corrections to existing functionality
• [CI]: Changes to build process or CI pipeline
• [Docs]: Updates or additions to documentation
• [API]: Modifications to aibrix's API or interface
• [CLI]: Changes or additions to the Command Line Interface
• [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

• PR title includes appropriate prefix(es)
• Changes are clearly explained in the PR description
• New and existing tests pass successfully
• Code adheres to project style and best practices
• Documentation updated to reflect changes (if applicable)
• Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

[gemini-code-assist]

Summary of Changes

Hello @googs1025, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request focuses on enhancing the stability and reliability of end-to-end tests by improving the mechanism for validating pod readiness. It replaces a basic, potentially flaky, polling loop with a more sophisticated and robust Kubernetes-native waiting utility, aiming to resolve intermittent test failures and improve overall test suite integrity.

Highlights

• Test Reliability Improvement: I've addressed a reported bug causing flaky end-to-end tests by replacing a fixed-iteration for loop with k8s.io/apimachinery/pkg/util/wait.PollUntilContextTimeout within the validateAllPodsAreReady function. This change makes the pod readiness check more robust and less susceptible to timing issues, as it continuously polls until the desired state is met or a timeout occurs.
• Code Readability and Maintainability: The refactor improves the readability and maintainability of the test utility code by leveraging a standard Kubernetes utility for polling. This replaces custom waiting logic with a well-established pattern, making the intent clearer and the code easier to understand and debug.
• Enhanced Error Handling and Context Management: The updated validateAllPodsAreReady function now uses a context.WithTimeout to properly manage the polling duration and asserts NoError on the polling result, providing clearer failure indications compared to the previous boolean assertion.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in issue comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request replaces a manual polling loop with wait.PollUntilContextTimeout to fix a flaky E2E test. This change enhances both the reliability and readability of the code. One suggestion is included to further simplify the implementation by removing a redundant context timeout.