Add configurable httproute timeout #1212
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @varungup90, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new configuration option that allows operators to customize the request timeout for HTTPRoute resources managed by the controller. This enhancement provides greater control over gateway behavior, ensuring better adaptability to varying network conditions or application requirements. Additionally, minor logging improvements have been made for ReferenceGrant resources.
Highlights
- Configurable HTTPRoute Timeout: The HTTPRoute request timeout can now be configured via the
AIBRIX_GATEWAY_TIMEOUT_SECONDSenvironment variable, providing flexibility for gateway interactions. - Default Timeout Value: The
controller-managerdeployment inmanager.yamlhas been updated to set a defaultAIBRIX_GATEWAY_TIMEOUT_SECONDSof 180 seconds, which the controller will use if the environment variable is not explicitly set. - Logging Improvement: Improved logging for
ReferenceGrantoperations inmodelrouter_controller.goto display only the name of the grant, making logs more concise and readable.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist is currently in preview and may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments to provide feedback.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
The pull request introduces a configurable HTTP route timeout by loading the timeout value from an environment variable. The changes also enhance logging for reference grants by including the name of the reference grant. Overall, the changes improve the configurability and observability of the system.
Signed-off-by: Varun Gupta <varungup90@gmail.com>
Jeffwan
force-pushed
the
gateway-timeout-configurable
branch
from
6d292ac to
07ac256
Compare
* Add configurable httproute timeout * nit --------- Signed-off-by: Varun Gupta <varungup90@gmail.com> Signed-off-by: Modi Tamam <modi.tamam@gmail.com>
* Add configurable httproute timeout * nit --------- Signed-off-by: Varun Gupta <varungup90@gmail.com>
Pull Request Description
[Please provide a clear and concise description of your changes here]
Related Issues
Resolves: #1207 #1176
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.