Skip to content

Conversation

varungup90
Copy link
Collaborator

Pull Request Description

[Please provide a clear and concise description of your changes here]

Related Issues

Resolves: #[Insert issue number(s)]

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@varungup90 varungup90 marked this pull request as draft May 8, 2025 18:48
@varungup90 varungup90 force-pushed the request-body-parsing-refactor branch from 2d02da9 to 9fbf635 Compare May 12, 2025 23:01
Signed-off-by: Varun Gupta <varungup90@gmail.com>
Signed-off-by: Varun Gupta <varungup90@gmail.com>
Signed-off-by: Varun Gupta <varungup90@gmail.com>
@varungup90 varungup90 force-pushed the request-body-parsing-refactor branch from 9fbf635 to d518360 Compare May 13, 2025 22:51
@varungup90 varungup90 marked this pull request as ready for review May 14, 2025 04:22
if strings.ToLower(n.Key) == "user" {
username = string(n.RawValue)
}
if strings.ToLower(n.Key) == "x-request-id" {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Jeffwan Jeffwan merged commit c157f65 into vllm-project:main May 15, 2025
13 checks passed
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
…ort (vllm-project#1067)

* Refactor request body processing and add multi-turn conversation support
* fix lint error
* add multiturn e2e test

---------

Signed-off-by: Varun Gupta <varungup90@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants