[Feature] AIBrix KVCache L2Cache Part3 and KVCache Managers #1064
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
May 7, 2025 15:15
- L2Cache - Unit test Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
- KVCacheManager and GroupAwareKVCacheManager - Unit tests Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-and-mgr
branch
from
8042e42 to
a0d0fc7
Compare
Jeffwan
approved these changes
May 7, 2025
| @@ -8,8 +8,6 @@ license-files = ["LICENSE"] | |||
| readme = "README.md" | |||
| repository = "https://github.com/vllm-project/aibrix/tree/main/python/aibrix_kvcache" | |||
| classifiers = [ | |||
| "Programming Language :: Python :: 3.9", | |||
| "Programming Language :: Python :: 3.10", | |||
There was a problem hiding this comment.
python 3.10 is not compatible? I see last PR 3.10 originally failed as well
There was a problem hiding this comment.
- Last PR failed due to the
fakeredislibrary (mocking redis server) used in testing the mete service module is not compatible with python 3.10, so I made pytest skip the related tests if using python 3.10. - In this PR, L2Cache uses asyncio.TaskGroup which is available since python 3.11. We could fix this compatibility issue in a separate PR.
itertools.batchedis also not compatible with 3.10 and 3.11, found a quick way to fix it, will push the changes soon.
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-and-mgr
branch
from
a0d0fc7 to
6b60874
Compare
We use several modules available since python 3.11 in L2Cache. Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-and-mgr
branch
from
6b60874 to
bc7ad67
Compare
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
…ject#1064) * [Feature] AIBrix KVCache L2Cache Part3 - L2Cache - Unit test * [Feature] AIBrix KVCache Manager - KVCacheManager and GroupAwareKVCacheManager - Unit tests * [CI]: add kvcache in release workflow * [Chore] remove python 3.9 and 3.10 We use several modules available since python 3.11 in L2Cache. --------- Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR includes all the rest changes of the AIBrix KVCache feature.
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.