[Feature] AIBrix KVCache L2Cache Part2 #1063
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-part2
branch
from
bc425c7 to
c8d8e98
Compare
Jeffwan
approved these changes
May 7, 2025
| logger = getLogger(__name__) | ||
|
|
||
|
|
||
| class RedisMetaService(MetaService): |
There was a problem hiding this comment.
the naming is a little bit confused here. is this a service? or client
There was a problem hiding this comment.
It's a client to access the meta service. What could be a suggested naming? We usually use meta service in other projects to refer to meta service clients as well.
There was a problem hiding this comment.
RedisMetadataClient or RedisMetadataBackend etc make more sense. This can be done in a separate PR.
|
seems the test filed are not formatted yet. Please help fix the ci and then let's merge this one |
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-part2
branch
from
c8d8e98 to
6d1d00c
Compare
- meta service module - placement module - Unit test for placement and meta service Meta service module has the same architectural level as L2Cache since it could be further extended to support more functionalities beyond current placement feature used by L2Cache. Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com>
DwyaneShi
force-pushed
the
haiyang/kvcache-l2cache-part2
branch
from
6d1d00c to
7788fde
Compare
Yaegaki1Erika
pushed a commit
to Yaegaki1Erika/aibrix
that referenced
this pull request
Jul 23, 2025
- meta service module - placement module - Unit test for placement and meta service Meta service module has the same architectural level as L2Cache since it could be further extended to support more functionalities beyond current placement feature used by L2Cache. Signed-off-by: Haiyang Shi <haiyang.shi@bytedance.com> Co-authored-by: Haiyang Shi <haiyang.shi@bytedance.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Description
This PR includes facilities to support L2Cache's cluster mode.
Meta service module has the same architectural level as L2Cache since it could be further extended to support more functionalities beyond current placement feature used by L2Cache.
Related Issues
Resolves: #[Insert issue number(s)]
Important: Before submitting, please complete the description above and review the checklist below.
Contribution Guidelines (Expand for Details)
We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:
Pull Request Title Format
Your PR title should start with one of these prefixes to indicate the nature of the change:
[Bug]: Corrections to existing functionality[CI]: Changes to build process or CI pipeline[Docs]: Updates or additions to documentation[API]: Modifications to aibrix's API or interface[CLI]: Changes or additions to the Command Line Interface[Misc]: For changes not covered above (use sparingly)Note: For changes spanning multiple categories, use multiple prefixes in order of importance.
Submission Checklist
By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.