Skip to content

Conversation

Jeffwan
Copy link
Collaborator

@Jeffwan Jeffwan commented May 2, 2025

Pull Request Description

  1. Add one personall access token from my personal account.(org account doesn't support such way)
  2. Update CI manifest to re-enable GHCR image build and push

Related Issues

Resolves: #734

Important: Before submitting, please complete the description above and review the checklist below.


Contribution Guidelines (Expand for Details)

We appreciate your contribution to aibrix! To ensure a smooth review process and maintain high code quality, please adhere to the following guidelines:

Pull Request Title Format

Your PR title should start with one of these prefixes to indicate the nature of the change:

  • [Bug]: Corrections to existing functionality
  • [CI]: Changes to build process or CI pipeline
  • [Docs]: Updates or additions to documentation
  • [API]: Modifications to aibrix's API or interface
  • [CLI]: Changes or additions to the Command Line Interface
  • [Misc]: For changes not covered above (use sparingly)

Note: For changes spanning multiple categories, use multiple prefixes in order of importance.

Submission Checklist

  • PR title includes appropriate prefix(es)
  • Changes are clearly explained in the PR description
  • New and existing tests pass successfully
  • Code adheres to project style and best practices
  • Documentation updated to reflect changes (if applicable)
  • Thorough testing completed, no regressions introduced

By submitting this PR, you confirm that you've read these guidelines and your changes align with the project's contribution standards.

@Jeffwan Jeffwan marked this pull request as draft May 2, 2025 16:56
@Jeffwan Jeffwan changed the title [CI] Enable GHCR image build and push [DO NOT MERGE] [CI] Enable GHCR image build and push May 2, 2025
@Jeffwan Jeffwan force-pushed the jiaxin/enable-ghcr-update branch 3 times, most recently from b08be5e to 8311a1c Compare May 2, 2025 17:08
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
@Jeffwan Jeffwan force-pushed the jiaxin/enable-ghcr-update branch from 8311a1c to 87f6a9e Compare May 2, 2025 17:11
@Jeffwan
Copy link
Collaborator Author

Jeffwan commented May 2, 2025

image
PR can not test this flow. Let's just merge it and so we can manual trigger the test flow

@Jeffwan Jeffwan marked this pull request as ready for review May 2, 2025 17:16
@Jeffwan Jeffwan changed the title [DO NOT MERGE] [CI] Enable GHCR image build and push [CI] Enable GHCR image build and push May 2, 2025
@Jeffwan Jeffwan requested a review from varungup90 May 2, 2025 17:23
@Jeffwan Jeffwan merged commit 540f7ac into vllm-project:main May 2, 2025
10 checks passed
Yaegaki1Erika pushed a commit to Yaegaki1Erika/aibrix that referenced this pull request Jul 23, 2025
Signed-off-by: Jiaxin Shan <seedjeffwan@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CICD] Release docker images on GHCR
2 participants