Skip to content

fix slh signature testing on latest version#26519

Merged
spytheman merged 2 commits intovlang:masterfrom
blackshirt:slhdsa_fix
Feb 6, 2026
Merged

fix slh signature testing on latest version#26519
spytheman merged 2 commits intovlang:masterfrom
blackshirt:slhdsa_fix

Conversation

@blackshirt
Copy link
Contributor

Its related in this issue#24086 encountered with latest changes. my test its fix the problem . @JalonSolov can you test this patch ?

@JalonSolov
Copy link
Contributor

JalonSolov commented Feb 5, 2026

Checked out this PR and... appears to be successful!

Switched to branch 'slhdsa_fix'
[jalon@7950x v]$ v -d has_modern_openssl test vlib/x/crypto/slhdsa
---- Testing... ----------------------------------------------------------------------------------------------------------------------------
 OK    [1/4] C:   214.0 ms, R:     8.097 ms vlib/x/crypto/slhdsa/slhdsa_sigver_test.v
 OK    [2/4] C:   206.2 ms, R:   215.942 ms vlib/x/crypto/slhdsa/usage_test.v
 OK    [3/4] C:   217.6 ms, R:   878.445 ms vlib/x/crypto/slhdsa/base_test.v
 OK    [4/4] C:   210.1 ms, R:  1435.859 ms vlib/x/crypto/slhdsa/slhdsa_siggen_test.v
--------------------------------------------------------------------------------------------------------------------------------------------
Summary for all V _test.v files: 4 passed, 4 total. Elapsed time: 1647 ms, on 4 parallel jobs. Comptime: 847 ms. Runtime: 2538 ms.
[jalon@7950x v]$

@blackshirt
Copy link
Contributor Author

blackshirt commented Feb 5, 2026

Checked out this PR and... appears to be successful!

Switched to branch 'slhdsa_fix'
[jalon@7950x v]$ v -d has_modern_openssl test vlib/x/crypto/slhdsa
---- Testing... ----------------------------------------------------------------------------------------------------------------------------
 OK    [1/4] C:   214.0 ms, R:     8.097 ms vlib/x/crypto/slhdsa/slhdsa_sigver_test.v
 OK    [2/4] C:   206.2 ms, R:   215.942 ms vlib/x/crypto/slhdsa/usage_test.v
 OK    [3/4] C:   217.6 ms, R:   878.445 ms vlib/x/crypto/slhdsa/base_test.v
 OK    [4/4] C:   210.1 ms, R:  1435.859 ms vlib/x/crypto/slhdsa/slhdsa_siggen_test.v
--------------------------------------------------------------------------------------------------------------------------------------------
Summary for all V _test.v files: 4 passed, 4 total. Elapsed time: 1647 ms, on 4 parallel jobs. Comptime: 847 ms. Runtime: 2538 ms.
[jalon@7950x v]$

Thank you for testing it. @spytheman is the CI fails related to this patch ? If not, i think its can be merged

@spytheman
Copy link
Member

Thank you for testing it. @spytheman is the CI fails related to this patch ? If not, i think its can be merged

The CI failures are not related, I will merge it asap (right after the other PR that fixes the -autofree job).

Thank you for working on this PR @blackshirt 🙇🏻 .
Excellent work.

@spytheman spytheman merged commit 794bd47 into vlang:master Feb 6, 2026
75 of 78 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants