Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

hash: replace .write method with io.Writer embedding #22009

Closed
wants to merge 1 commit into from
Closed

hash: replace .write method with io.Writer embedding #22009

wants to merge 1 commit into from

Conversation

einar-hjortdal
Copy link
Contributor

@einar-hjortdal einar-hjortdal commented Aug 8, 2024 •
edited
Loading

Minor change as suggested in #22001

@spytheman
Copy link
Member

spytheman commented Aug 8, 2024 •
edited
Loading

It is a single method declaration. We do not need to import io just for that.
To borrow one of Go's aphorisms, "a little copying is better than a little dependency".

@spytheman spytheman closed this Aug 8, 2024
@einar-hjortdal
Copy link
Contributor Author

Sounds good to me!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@einar-hjortdal @spytheman