Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update binary artifact workflow, add matrix #21378

Merged
merged 4 commits into from
May 6, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Apr 29, 2024

Same as with a recent matrix related CI update:

Makes use of a matrix for jobs that share the same steps cross-platform or have marginal differences. This allows for easier and more consistent changes, and should simplify maintainability by reducing redundancy and eliminating the need to update and review the same things in multiple places.

While the changes manage to mainly simplify things, they also include improvements.

Notable changes concern only Windows release archives:

  • data structure that allows for more platform consistency / independency when downloading and viewing the contents of a Windows archive.
    Example screenshots showing directories and archives in comparison on a Linux system:

    • Current - Windows and Linux directories after extraction on the left and archives on the right (windows is flat)
      Screenshot_20240429_191308

    • Updated - Windows and Linux directories after extraction on the left and windows archive on the right.
      Screenshot_20240429_190102

  • building is more than twice as fast (secondary for that workflow, but still notable)

Ref. CI runs:


It's one of the last planed rougher-/maintenance-changes to the CI, before moving towards suggestions that are more enhancement-based.

@spytheman
Copy link
Member

No. I do not want any drastic changes in this CI script.

It works as it is (after fixing it today), and given that it is used once per week, if it breaks again in subtle ways (which is very likely given the changes), we will understand with a huge delay next week.

@spytheman spytheman closed this Apr 29, 2024
@ttytm
Copy link
Member Author

ttytm commented Apr 29, 2024

@spytheman the only change here is related to the artifact creation.
There are no changes to how things are uploaded or releases created. So as long as the release artifacts are added and named the same (which can be viewed in the workflow runs) there will be no difference.

Would it be an option to leave it open until next week. Or if I create a release on a fork to show you that it works?

@ttytm ttytm reopened this Apr 29, 2024
@ttytm ttytm closed this Apr 29, 2024
@spytheman
Copy link
Member

spytheman commented Apr 29, 2024

Would it be an option to leave it open until next week. Or if I create a release on a fork to show you that it works?

You can create a release on a fork, but I do prefer for this PR to stay closed (or a draft), until next Monday.

@spytheman
Copy link
Member

I will test it more thoroughly today.

@spytheman spytheman reopened this May 6, 2024
@ttytm
Copy link
Member Author

ttytm commented May 6, 2024

@ttytm
Copy link
Member Author

ttytm commented May 6, 2024

What about also renaming it into Release CI? This would be the common name for this kind of action.

@spytheman
Copy link
Member

What about also renaming it into Release CI? This would be the common name for this kind of action.

Yes, that is a good idea. It will simplify searching for it.

@spytheman
Copy link
Member

Both the name: and the .yml file?

@spytheman
Copy link
Member

Excellent work.

@spytheman spytheman merged commit 476e939 into vlang:master May 6, 2024
10 checks passed
@ttytm ttytm deleted the ci/bin-artifact-matrix branch May 6, 2024 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants