-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ci: update binary artifact workflow, add matrix #21378
Conversation
No. I do not want any drastic changes in this CI script. It works as it is (after fixing it today), and given that it is used once per week, if it breaks again in subtle ways (which is very likely given the changes), we will understand with a huge delay next week. |
@spytheman the only change here is related to the artifact creation. Would it be an option to leave it open until next week. Or if I create a release on a fork to show you that it works? |
You can create a release on a fork, but I do prefer for this PR to stay closed (or a draft), until next Monday. |
I will test it more thoroughly today. |
Ref. run and release at latest state after 82b79b2 |
What about also renaming it into |
Yes, that is a good idea. It will simplify searching for it. |
Both the name: and the .yml file? |
Excellent work. |
Same as with a recent matrix related CI update:
While the changes manage to mainly simplify things, they also include improvements.
Notable changes concern only Windows release archives:
data structure that allows for more platform consistency / independency when downloading and viewing the contents of a Windows archive.
Example screenshots showing directories and archives in comparison on a Linux system:
Current - Windows and Linux directories after extraction on the left and archives on the right (windows is flat)
Updated - Windows and Linux directories after extraction on the left and windows archive on the right.
building is more than twice as fast (secondary for that workflow, but still notable)
Ref. CI runs:
It's one of the last planed rougher-/maintenance-changes to the CI, before moving towards suggestions that are more enhancement-based.