Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

thirdparty,net.mbedtls: update mbedtls to latest compatible version v3.3.0 #21118

Merged
merged 7 commits into from
Mar 28, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 27, 2024

Big update of the mbedtls library to it's latest compatible release. The current latest release 3.5.2 works on linux and macos, but runs into general compatibility issues on Windows. Version 3.4.x on encounters issues on Windows with tcc. It can likely be used after our tcc upgrade.

Notes to the reviewer:

  1. The commit update thirdpary/mbedtls to 3.3.0 only updates thirdparty files. If it helps with the review process / verifying legitimacy, add the git directory of the library at the state of the release.
    For example, pull the library to a local directory, then add its .git directory to Vs thirdparty/mbedtls. There should be no changes to the libraries files besides deleting unused files (for Vs codebase it follows same practice as before - not including superfluous files).
    # pull Mbed-TLS/mbedtls.git at v3.3.0 to access its .git dir 
    git clone --depth=1 --recursive --shallow-submodules --single-branch -b v3.3.0 https://github.com/Mbed-TLS/mbedtls.git

@ttytm ttytm marked this pull request as draft March 27, 2024 17:01
@ttytm ttytm marked this pull request as ready for review March 27, 2024 17:28
@ttytm
Copy link
Member Author

ttytm commented Mar 27, 2024

I "slightly dislike" Windows... Gonna paddle one version back, it is before a move towards a newer Windows API. This might be less headache with Windows compatibility.

@ttytm ttytm changed the title net.mbedtls: update to latest release version 3.5.2 net.mbedtls: update thirdparty/mbedtls to latest compatible version Mar 28, 2024
@spytheman spytheman changed the title net.mbedtls: update thirdparty/mbedtls to latest compatible version net.mbedtls: update thirdparty/mbedtls to latest compatible version v3.3.0 Mar 28, 2024
@spytheman spytheman changed the title net.mbedtls: update thirdparty/mbedtls to latest compatible version v3.3.0 thirdparty,net.mbedtls: update mbedtls to latest compatible version v3.3.0 Mar 28, 2024
@spytheman spytheman merged commit 64a3369 into vlang:master Mar 28, 2024
41 of 42 checks passed
@ttytm ttytm deleted the net/update-mbedtls branch April 16, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants