Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parser, fmt: parse methods on JS interfaces, write JS method bodies #21088

Merged
merged 5 commits into from
Mar 25, 2024
Merged

parser, fmt: parse methods on JS interfaces, write JS method bodies #21088

merged 5 commits into from
Mar 25, 2024

Conversation

ttytm
Copy link
Member

@ttytm ttytm commented Mar 24, 2024

Builds on #21070 and it's comments.

Adds a test for the scenario and for #12447.

spytheman
spytheman approved these changes Mar 25, 2024
View reviewed changes
Copy link
Member

@spytheman spytheman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent work.

@spytheman spytheman merged commit e7ed073 into vlang:master Mar 25, 2024
54 checks passed
@ttytm ttytm deleted the parser/parse-js-interop-methods branch March 25, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@spytheman spytheman spytheman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ttytm @spytheman