Make 5.1 audio work again #35
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add rudimentary but functional Firefox options panel with checkbox to offer 5.1 audio if available.
Mozilla has a hard limit of 4 MB maximum on files to be signed in extensions. The cadmium-playercore-1080p.js file is already very close to that limit (3.94 MB). When git clones the repository to a Windows client, it changes all of the LF to CRLF in each file in the repository. This is usually no problem for most files, but causes the cadmium js file to exceed 4 MB, thus preventing Windows clients from self-signing the extension and testing code updates. This commit simply adds a .gitattributes file with a single line that tells git to refrain from replacing LF with CRLF for the cadmium js file. If the cadmium js file is renamed in the future, this .gitattributes file will need to be updated. I have tested this on my Windows client and it solves the problem. Mac and Linux clients will be unaffected since they already use LF instead of CRLF.
|
Added one-liner .gitattributes file so Windows clients can sign the extension (see commit comment). Reason for change: #31 (comment) |
MrPryor
approved these changes
Jan 10, 2020
vladikoff
approved these changes
Jan 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add rudimentary but functional Firefox options panel with checkbox to offer 5.1 audio if available. The options panel is accessible by clicking on Netflix 1080p in the about:addons list. (There is still no toolbar icon.)
Other than changing a few keywords to Firefox API, this PR is mostly adapted straight from the truedread extension. See the Commit comment for further details. I was able to test and confirm that 5.1 audio now works with this extension and Firefox 69 (only if enabled in options, of course). Could close Issue #22 if others can verify.
This opens the door for someone else to implement the Max Bitrate setting and add it to the options panel. I didn't understand truedread's code for that option so I omitted it.