Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Null for nested params #12

Closed
vladfaust opened this issue Oct 26, 2018 · 0 comments
Closed

Allow Null for nested params #12

vladfaust opened this issue Oct 26, 2018 · 0 comments
Labels
enhancement New feature or request

Comments

@vladfaust
Copy link
Owner

vladfaust commented Oct 26, 2018 •
edited
Loading 

{
  user: {
    id: Int32
  } | Nil | Null
}
@vladfaust vladfaust added the enhancement New feature or request label Oct 26, 2018
@vladfaust vladfaust mentioned this issue Nov 23, 2018
Closed
vladfaust added a commit that referenced this issue Dec 16, 2018
@vladfaust
overhaul: move to annotations-based approach
4f4928d 
There is no more `Params.parse`, the brand new `HTTP::Params::Serializable` module has a new API similar to `JSON::Serializable`.

Closes #2 as there are no getters generated anymore.
Closes #3 because JSON serialization can be made with `JSON::Serializable`.
Closes #4.
Closes #7.
Related to #8.
Closes #9.
Closes #10.
Closes #12 because there are no more `Null` types.
Closes #13 (there is a Kemal example in the README).
Closes #14 because accessing instance variables is not the module's responsibility anymore.
Closes #15 because ditto.
Closes #16.
Closes #17.
And finally, closes #18.
vladfaust added a commit that referenced this issue Dec 16, 2018
@vladfaust
overhaul: move to annotations-based approach
0464d8b 
There is no more `Params.parse`, the brand new `HTTP::Params::Serializable` module has a new API similar to `JSON::Serializable`.

Closes #2 as there are no getters generated anymore.
Closes #3 because JSON serialization can be made with `JSON::Serializable`.
Closes #4.
Closes #7.
Related to #8.
Closes #9.
Closes #10.
Closes #12 because there are no more `Null` types.
Closes #13 (there is a Kemal example in the README).
Closes #14 because accessing instance variables is not the module's responsibility anymore.
Closes #15 because ditto.
Closes #16.
Closes #17.
And finally, closes #18.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vladfaust