Skip to content

Commit

Permalink
Put the org in astro.config instead of passing it through env vars.
Browse files Browse the repository at this point in the history
  • Loading branch information
jyasskin committed Jan 24, 2024
1 parent 1f04a49 commit 541a28c
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 7 deletions.
7 changes: 2 additions & 5 deletions .github/workflows/staging.yml
Original file line number Diff line number Diff line change
Expand Up @@ -12,9 +12,6 @@ jobs:
name: staging
url: "https://vlach-cookbook-staging.fly.dev/"
if: ${{ github.event.workflow_run.conclusion == 'success' }}
env:
SENTRY_ORG: jeffrey-yasskin
SENTRY_PROJECT: vlach-cookbook
steps:
- uses: actions/checkout@v4
with:
Expand All @@ -23,6 +20,8 @@ jobs:
uses: getsentry/action-release@v1
env:
SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }}
SENTRY_ORG: jeffrey-yasskin
SENTRY_PROJECT: vlach-cookbook
with:
environment: staging
finalize: false
Expand All @@ -34,8 +33,6 @@ jobs:
flyctl deploy webserver \
--build-arg GOOGLE_SITE_VERIFICATION="$GOOGLE_SITE_VERIFICATION" \
--build-arg SENTRY_DSN="$SENTRY_DSN" \
--build-arg SENTRY_ORG="$SENTRY_ORG" \
--build-arg SENTRY_PROJECT="$SENTRY_PROJECT" \
--build-secret SENTRY_AUTH_TOKEN="$SENTRY_AUTH_TOKEN" \
--build-arg SENTRY_RELEASE="$GITHUB_SHA" \
--build-arg SENTRY_ENVIRONMENT=staging
Expand Down
2 changes: 0 additions & 2 deletions webserver/Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,8 +17,6 @@ COPY . .
ARG GOOGLE_SITE_VERIFICATION
RUN if [ -n "${GOOGLE_SITE_VERIFICATION}" ]; then mkdir -p public; echo "google-site-verification: ${GOOGLE_SITE_VERIFICATION}" > public/${GOOGLE_SITE_VERIFICATION}; fi
ARG SENTRY_DSN
ARG SENTRY_ORG
ARG SENTRY_PROJECT
ARG SENTRY_RELEASE
ARG SENTRY_ENVIRONMENT
RUN --mount=type=secret,id=SENTRY_AUTH_TOKEN \
Expand Down
1 change: 1 addition & 0 deletions webserver/astro.config.mjs
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ export default defineConfig({
release: process.env.SENTRY_RELEASE,
environment: process.env.SENTRY_ENVIRONMENT ?? "development",
sourceMapsUploadOptions: {
org: "jeffrey-yasskin",
project: "vlach-cookbook",
authToken: process.env.SENTRY_AUTH_TOKEN,
},
Expand Down

0 comments on commit 541a28c

Please sign in to comment.