Skip to content

[REFERENCE] All combined #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
matthewhively wants to merge 25 commits into
base: old_master
Choose a base branch
from
Draft

[REFERENCE] All combined #1

matthewhively wants to merge 25 commits into from

Conversation

@matthewhively
Copy link
Collaborator

@matthewhively matthewhively commented Nov 14, 2025 •
edited
Loading

Includes the following changes (in broad strokes)

  1. Use a config option Redis::Objects.prefix_style to control legacy or modern mode.
    • :legacy before upgrade
    • :modern after upgrade
  2. Update migrate_redis_legacy_keys to NOOP if no migration is necessary
  3. Adjust the redis_legacy_naming_warning_message to actually make sense

@matthewhively
Rename this unit test
3f61a48
@matthewhively
README updated 2.0.0 release notes to better match behavior
304b377
@matthewhively
spacing
8579b66
@matthewhively
move variables
14bb536
@matthewhively
redis_legacy_naming_warning_message uses guard clause return
288742a 
Less indentation needed.
@matthewhively
README updates
45440f0 
 - updated 2.0.0 release notes to better match behavior
 - Added a section for additional notes that don't really fit into another section
 - Re-arranged redis connection/pool descriptions
 - Added links to the 2 main usage options from the overview
 - Clarification on ORM
 - Added more explanation about global redis-objects
@matthewhively
Use Redis::Objects.prefix_style to manage legacy => modern prefix update
543265f 
And updated the README for revised logic
@matthewhively
Document some behavior in class inheritance
1cfa217
@matthewhively
Comments
c6c1d27
@matthewhively
Added example of custom keys to readme
32ba536
@matthewhively
Fix migrate_redis_legacy_keys to temporarily use ":modern" prefix
bdb3020
@matthewhively
Require the duration extensions
0f14987 
Dunno how the tests passed previously without this
@matthewhively
Nest the key_naming_spec tests
019a344 
contexts don't exist in "bacon", so use nested "describe" blocks instead.
@matthewhively
Remove pointless assertions
84687ee
@matthewhively
Remove nonsense shoulds
f285105
@matthewhively
More nonsense, redis host is already defined globally
d6ed481
@matthewhively
Update key_naming migration method test
affca83 
 - Only using a single class now named `UpgradeTest`
 - Class is deleted and recreated to switch between legacy & modern conventions
@matthewhively
Update the other key_naming tests
28ccf6f
@matthewhively
Merge readme_and_comments into all_combined
285cc94
@matthewhively
Add scan_count & verbose mode for migrate_redis_legacy_keys
d9274fe 
Use a large number for spec testing
@matthewhively
Sort the redis keys
24edf2a 
For consistency in test output
@matthewhively
Update migrate_redis_legacy_keys to NOOP if no changes are needed
6edbb6a 
Additional minor refactors
@matthewhively
Remove useless variables from migrate_redis_legacy_keys
d7779da
@matthewhively
Tweak upgrade warning message
f496b4d
@matthewhively
Merge migration into all_combined
3ea1dd6
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@matthewhively