-
-
Notifications
You must be signed in to change notification settings - Fork 18
Add failing tests #26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d05ea53
chore: allow empty str
fundon baf89db
chore(tree): dont replace pieces
fundon 1545a59
chore: clean
fundon 8621267
add failing tests
adriangb 7b27d16
fmt
adriangb a1f13c5
chore: name and value should be overwritten
fundon 6163577
Merge remote-tracking branch 'upstream/allow_empty_str' into add-tests
adriangb d60978b
simplify test
adriangb 1fc018c
chore: allow insert empty str
fundon d78642c
Merge remote-tracking branch 'upstream/allow_empty_str' into add-tests
adriangb b22bd5e
Merge remote-tracking branch 'upstream/main' into add-tests
adriangb File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -3,7 +3,9 @@ use rand::seq::SliceRandom; | |
|
||
#[test] | ||
fn statics() { | ||
const ROUTES: [&str; 11] = [ | ||
const ROUTES: [&str; 13] = [ | ||
"", | ||
"/", | ||
"/hi", | ||
"/contact", | ||
"/co", | ||
|
@@ -128,6 +130,19 @@ fn single_named_parameter() { | |
} | ||
} | ||
|
||
#[test] | ||
fn repeated_single_named_param() { | ||
let mut tree = PathTree::new(); | ||
|
||
tree.insert("/users/:id", 0); | ||
tree.insert("/users/:user_id", 1); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. @adriangb Both the name and the value should be overwritten |
||
|
||
let r = tree.find("/users/gordon"); | ||
let path = r.unwrap(); | ||
assert_eq!(*path.value, 1); | ||
assert_eq!(path.params(), vec![("user_id", "gordon")]); | ||
} | ||
|
||
#[test] | ||
fn static_and_named_parameter() { | ||
// Pattern: /a/b/c | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Separate this line out, it will be overwritten by
/
and left here they will be randomly broken up and have different values, causing the test to fail.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't really understand. Are you saying that having
""
and"/"
is supported but not at the same time?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are lines of operations below that will shuffle the array.
routes.shuffle(&mut rand::thread_rng());