[plugin-activeMQ] WIP Add possibility to send messages in ActiveMQ #4855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
valfirst
requested changes
Feb 27, 2024
| @@ -0,0 +1,18 @@ | |||
| project.description = 'VIVIDUS plugin for Apache Kafka' | |||
There was a problem hiding this comment.
Suggested change
| project.description = 'VIVIDUS plugin for Apache Kafka' | |
| project.description = 'VIVIDUS plugin for Apache ActiveMQ' |
| testImplementation(group: 'org.junit.jupiter', name: 'junit-jupiter') | ||
| testImplementation platform(group: 'org.mockito', name: 'mockito-bom', version: '5.10.0') | ||
| testImplementation(group: 'org.mockito', name: 'mockito-junit-jupiter') | ||
| testImplementation(group: 'org.springframework.kafka', name: 'spring-kafka-test') |
| { | ||
| public static void main(String[] args) | ||
| { | ||
| System.out.println("Hello world!"); |
There was a problem hiding this comment.
| private String password = "admin"; | ||
| private String brokerUrl = "tcp://0.0.0.0:61616"; | ||
|
|
||
| @When("I send message to activeMQ $type with name `$name` and payload:$payload") |
There was a problem hiding this comment.
Suggested change
| @When("I send message to activeMQ $type with name `$name` and payload:$payload") | |
| @When("I send message to ActiveMQ $channel with name `$name` and payload:`$payload`") |
| @When("I send message to activeMQ $type with name `$name` and payload:$payload") | ||
| public void sendMessageToActiveMQ(MessageType type, String name, String payload) throws JMSException | ||
| { | ||
| ActiveMQConnectionFactory connectionFactory = new ActiveMQConnectionFactory(brokerUrl); |
There was a problem hiding this comment.
please make sure to reuse parts which shared across threads
Comment on lines
+13
to
+15
| private String username = "admin"; | ||
| private String password = "admin"; | ||
| private String brokerUrl = "tcp://0.0.0.0:61616"; |
There was a problem hiding this comment.
make sure these will be configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.