forked from camunda/camunda-bpm-platform
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
chore(ldap): add property to throw authentication exceptions in pw check
Related to camunda#3474
- Loading branch information
Showing
7 changed files
with
136 additions
and
13 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 2 additions & 0 deletions
2
distro/run/core/src/test/resources/application-test-ldap-auth-exception.yml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,2 @@ | ||
| camunda.bpm.run.ldap: | ||
| password-check-catch-authentication-exception: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
53 changes: 53 additions & 0 deletions
53
...st/java/org/camunda/bpm/identity/impl/ldap/LdapLoginCatchAuthenticationExceptionTest.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,53 @@ | ||
| /* | ||
| * Copyright Camunda Services GmbH and/or licensed to Camunda Services GmbH | ||
| * under one or more contributor license agreements. See the NOTICE file | ||
| * distributed with this work for additional information regarding copyright | ||
| * ownership. Camunda licenses this file to you under the Apache License, | ||
| * Version 2.0; you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.camunda.bpm.identity.impl.ldap; | ||
|
|
||
| import static org.assertj.core.api.Assertions.assertThatThrownBy; | ||
|
|
||
| import org.camunda.bpm.engine.IdentityService; | ||
| import org.camunda.bpm.engine.test.ProcessEngineRule; | ||
| import org.camunda.bpm.identity.ldap.util.LdapTestEnvironmentRule; | ||
| import org.junit.Before; | ||
| import org.junit.ClassRule; | ||
| import org.junit.Rule; | ||
| import org.junit.Test; | ||
|
|
||
| public class LdapLoginCatchAuthenticationExceptionTest { | ||
|
|
||
| @ClassRule | ||
| public static LdapTestEnvironmentRule ldapRule = new LdapTestEnvironmentRule(); | ||
|
|
||
| @Rule | ||
| public ProcessEngineRule engineRule = new ProcessEngineRule("camunda.ldap.disable.catch.authentication.exception.cfg.xml"); | ||
|
|
||
| IdentityService identityService; | ||
|
|
||
| @Before | ||
| public void setup() { | ||
| identityService = engineRule.getIdentityService(); | ||
| } | ||
|
|
||
| @Test | ||
| public void shouldThrowExceptionOnFailedLogin() { | ||
| // given config passwordCheckCatchAuthenticationException=false | ||
|
|
||
| // when | ||
| assertThatThrownBy(() -> identityService.checkPassword("roman", "wrongPW")) | ||
| .isInstanceOf(LdapAuthenticationException.class) | ||
| .hasMessage("Could not authenticate with LDAP server"); | ||
| } | ||
| } |
58 changes: 58 additions & 0 deletions
58
...ntity-ldap/src/test/resources/camunda.ldap.disable.catch.authentication.exception.cfg.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,58 @@ | ||
| <?xml version="1.0" encoding="UTF-8"?> | ||
|
|
||
| <beans xmlns="http://www.springframework.org/schema/beans" | ||
| xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance" | ||
| xsi:schemaLocation="http://www.springframework.org/schema/beans http://www.springframework.org/schema/beans/spring-beans.xsd"> | ||
|
|
||
| <bean id="processEngineConfiguration" class="org.camunda.bpm.engine.impl.cfg.StandaloneInMemProcessEngineConfiguration"> | ||
|
|
||
| <property name="processEngineName" value="LdapLoginCatchAuthenticationExceptionTest-engine" /> | ||
|
|
||
| <property name="jdbcUrl" value="jdbc:h2:mem:LdapLoginCatchAuthenticationExceptionTest;DB_CLOSE_DELAY=1000" /> | ||
| <property name="jdbcDriver" value="org.h2.Driver" /> | ||
| <property name="jdbcUsername" value="sa" /> | ||
| <property name="jdbcPassword" value="" /> | ||
|
|
||
| <!-- Database configurations --> | ||
| <property name="history" value="audit" /> | ||
| <property name="databaseSchemaUpdate" value="create-drop" /> | ||
|
|
||
| <!-- job executor configurations --> | ||
| <property name="jobExecutorActivate" value="false" /> | ||
|
|
||
| <property name="createDiagramOnDeploy" value="true" /> | ||
|
|
||
| <property name="processEnginePlugins"> | ||
| <list> | ||
| <ref bean="ldapIdentityProviderPlugin" /> | ||
| </list> | ||
| </property> | ||
|
|
||
| </bean> | ||
|
|
||
| <bean id="ldapIdentityProviderPlugin" class="org.camunda.bpm.identity.impl.ldap.plugin.LdapIdentityProviderPlugin"> | ||
|
|
||
| <property name="serverUrl" value="ldap://localhost:${ldap.server.port}/" /> | ||
| <property name="managerDn" value="uid=daniel,ou=office-berlin,o=camunda,c=org" /> | ||
| <property name="managerPassword" value="daniel" /> | ||
| <property name="baseDn" value="o=camunda,c=org" /> | ||
|
|
||
| <property name="userSearchBase" value="" /> | ||
| <property name="userSearchFilter" value="(objectclass=person)" /> | ||
| <property name="userIdAttribute" value="uid" /> | ||
| <property name="userFirstnameAttribute" value="cn" /> | ||
| <property name="userLastnameAttribute" value="sn" /> | ||
| <property name="userEmailAttribute" value="mail" /> | ||
| <property name="userPasswordAttribute" value="userpassword" /> | ||
|
|
||
| <property name="groupSearchBase" value="" /> | ||
| <property name="groupSearchFilter" value="(objectclass=groupOfNames)" /> | ||
| <property name="groupIdAttribute" value="ou" /> | ||
| <property name="groupNameAttribute" value="cn" /> | ||
| <property name="groupMemberAttribute" value="member" /> | ||
|
|
||
| <property name="passwordCheckCatchAuthenticationException" value="false" /> | ||
|
|
||
| </bean> | ||
|
|
||
| </beans> |